Skip to content

Commit abc1e1c

Browse files
committed
fix: remove unused isopen
1 parent 8c2d07f commit abc1e1c

3 files changed

Lines changed: 2 additions & 5 deletions

File tree

packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelection.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,13 @@ export function MultiSelection({
101101
const ariaLabels = useMemo(
102102
() =>
103103
getComboboxAriaLabels({
104-
isOpen,
105104
hasSelection: selectedItems.length > 0,
106105
selectedValue: selectedItems.map(id => selector.caption.get(id)).join(", "),
107106
inputLabel,
108107
labelledBy: inputProps["aria-labelledby"],
109108
fallbackAriaLabel: options.ariaLabel
110109
}),
111-
[isOpen, selectedItems, inputLabel, inputProps, options.ariaLabel, selector.caption]
110+
[selectedItems, inputLabel, inputProps, options.ariaLabel, selector.caption]
112111
);
113112

114113
return (

packages/pluggableWidgets/combobox-web/src/components/SingleSelection/SingleSelection.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,13 @@ export function SingleSelection({
8787
const ariaLabels = useMemo(
8888
() =>
8989
getComboboxAriaLabels({
90-
isOpen,
9190
hasSelection: Boolean(selectedItem),
9291
selectedValue: selectedItem ? selector.caption.get(selectedItem) : "",
9392
inputLabel,
9493
labelledBy: inputProps["aria-labelledby"],
9594
fallbackAriaLabel: options.ariaLabel
9695
}),
97-
[isOpen, selectedItem, inputLabel, inputProps, options.ariaLabel, selector.caption]
96+
[selectedItem, inputLabel, inputProps, options.ariaLabel, selector.caption]
9897
);
9998

10099
return (

packages/pluggableWidgets/combobox-web/src/helpers/utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ export function getValidationErrorId(inputId?: string): string | undefined {
173173
* aria-label to be announced, we must NOT set aria-labelledby at all.
174174
*/
175175
export function getComboboxAriaLabels(params: {
176-
isOpen: boolean;
177176
hasSelection: boolean;
178177
selectedValue: string;
179178
inputLabel: Element | null;

0 commit comments

Comments
 (0)