Skip to content

Commit ded8515

Browse files
authored
fix: act() warnings (#2241)
2 parents 088acab + 5cf0ca2 commit ded8515

1 file changed

Lines changed: 12 additions & 15 deletions

File tree

packages/pluggableWidgets/datagrid-number-filter-web/src/components/__tests__/DatagridNumberFilter.spec.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,10 @@ describe("Number Filter", () => {
8888
render(<DatagridNumberFilter {...commonProps} onChange={action} valueAttribute={attribute} />);
8989

9090
const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
91-
await user.type(screen.getByRole("textbox"), "10");
9291

93-
act(() => {
94-
jest.runOnlyPendingTimers();
92+
await act(async () => {
93+
await user.type(screen.getByRole("textbox"), "10");
94+
jest.runAllTimers();
9595
});
9696

9797
expect(action.execute).toHaveBeenCalledTimes(1);
@@ -107,10 +107,8 @@ describe("Number Filter", () => {
107107
expect(input).toHaveValue("");
108108

109109
const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
110-
await user.type(input, "42");
111-
112-
// Run timers for the debounced setValue
113-
act(() => {
110+
await act(async () => {
111+
await user.type(input, "42");
114112
jest.runAllTimers();
115113
});
116114

@@ -161,11 +159,10 @@ describe("Number Filter", () => {
161159
expect(input).toHaveValue("123");
162160

163161
const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
164-
// set input empty
165-
await user.clear(input);
166-
await user.type(input, "42");
167162

168-
act(() => {
163+
await act(async () => {
164+
await user.clear(input);
165+
await user.type(input, "42");
169166
jest.runAllTimers();
170167
});
171168

@@ -232,9 +229,9 @@ describe("Number Filter", () => {
232229
expect(input).toHaveValue("");
233230

234231
const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
235-
await user.type(input, "42");
236232

237-
act(() => {
233+
await act(async () => {
234+
await user.type(input, "42");
238235
jest.runAllTimers();
239236
});
240237

@@ -257,9 +254,9 @@ describe("Number Filter", () => {
257254
expect(input).toHaveValue("");
258255

259256
const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime });
260-
await user.type(input, "42");
261257

262-
act(() => {
258+
await act(async () => {
259+
await user.type(input, "42");
263260
jest.runAllTimers();
264261
});
265262

0 commit comments

Comments
 (0)