Skip to content

chore: remove react test renderer, rewrite carousel tests #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r0b1n merged 1 commit into from
Jul 29, 2025
Merged

chore: remove react test renderer, rewrite carousel tests #1798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/carousel-web/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const base = require("@mendix/pluggable-widgets-tools/test-config/jest.config");
const base = require("@mendix/pluggable-widgets-tools/test-config/jest.enzyme-free.config.js");

module.exports = {
...base,
Expand Down
2 changes: 0 additions & 2 deletions packages/pluggableWidgets/carousel-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@
},
"dependencies": {
"@mendix/widget-plugin-component-kit": "workspace:*",
"@types/react-test-renderer": "^18.0.7",
"classnames": "^2.5.1",
"react-test-renderer": "^18.2.0",
"swiper": "^9.4.1"
},
"devDependencies": {
Expand Down
24 changes: 14 additions & 10 deletions packages/pluggableWidgets/carousel-web/src/components/__tests__/Carousel.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import { createElement } from "react";
import { Carousel, CarouselProps } from "../Carousel";
import renderer from "react-test-renderer";
import { render } from "@testing-library/react";
import { GUID } from "mendix";

beforeEach(() => {
jest.resetAllMocks();
});
describe("Carousel", () => {
beforeEach(() => {
jest.resetAllMocks();
jest.spyOn(Math, "random").mockReturnValue(0.123456789);
});
const defaultCarouselProps: CarouselProps = {
id: "Carousel",
className: "",
Expand All @@ -24,18 +25,21 @@ describe("Carousel", () => {
};

it("renders correctly", () => {
const carousel = renderer.create(<Carousel {...defaultCarouselProps} />);
const { asFragment } = render(<Carousel {...defaultCarouselProps} />);

expect(carousel).toMatchSnapshot();
expect(asFragment()).toMatchSnapshot();
});
it("renders correctly without pagination", () => {
const carousel = renderer.create(<Carousel {...defaultCarouselProps} pagination={false} />);
const { asFragment } = render(<Carousel {...defaultCarouselProps} pagination={false} />);

expect(carousel).toMatchSnapshot();
expect(asFragment()).toMatchSnapshot();
});
it("renders correctly without navigation", () => {
const carousel = renderer.create(<Carousel {...defaultCarouselProps} navigation={false} />);
const { asFragment } = render(<Carousel {...defaultCarouselProps} navigation={false} />);

expect(carousel).toMatchSnapshot();
expect(asFragment()).toMatchSnapshot();
});
afterEach(() => {
jest.restoreAllMocks();
});
});
284 changes: 187 additions & 97 deletions ...uggableWidgets/carousel-web/src/components/__tests__/__snapshots__/Carousel.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,124 +1,214 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Carousel renders correctly 1`] = `
<div
className="widget-carousel"
>
<DocumentFragment>
<div
className="swiper"
class="widget-carousel"
>
<ul
className="swiper-wrapper"
<div
class="swiper swiper-fade swiper-initialized swiper-horizontal swiper-watch-progress"
>
<li
aria-hidden={false}
className="swiper-slide"
id="carousel-slide-Carousel-1"
onLoad={[Function]}
<ul
aria-live="off"
class="swiper-wrapper"
id="swiper-wrapper-2222222222222222"
style="transition-duration: 0ms;"
>
<div>
test1
</div>
</li>
<li
aria-hidden={true}
className="swiper-slide"
id="carousel-slide-Carousel-2"
onLoad={[Function]}
<li
aria-hidden="false"
aria-label="1 / 2"
class="swiper-slide"
data-swiper-slide-index="0"
id="carousel-slide-Carousel-1"
role="listitem"
>
<div>
test1
</div>
</li>
<li
aria-hidden="true"
aria-label="2 / 2"
class="swiper-slide"
data-swiper-slide-index="1"
id="carousel-slide-Carousel-2"
role="listitem"
>
<div>
test2
</div>
</li>
</ul>
<div
aria-controls="swiper-wrapper-2222222222222222"
aria-label="Previous slide"
class="swiper-button-prev"
role="button"
tabindex="0"
/>
<div
aria-controls="swiper-wrapper-2222222222222222"
aria-label="Next slide"
class="swiper-button-next"
role="button"
tabindex="0"
/>
<div
class="swiper-pagination swiper-pagination-clickable swiper-pagination-bullets swiper-pagination-horizontal"
>
<div>
test2
</div>
</li>
</ul>
<div
className="swiper-button-prev"
/>
<div
className="swiper-button-next"
/>
<div
className="swiper-pagination"
/>
<span
aria-controls="carousel-slide-Carousel-1"
aria-current="true"
aria-label="Go to slide 0"
class="swiper-pagination-bullet swiper-pagination-bullet-active"
role="button"
tabindex="0"
/>
<span
aria-controls="carousel-slide-Carousel-2"
aria-label="Go to slide 1"
class="swiper-pagination-bullet"
role="button"
tabindex="0"
/>
</div>
<span
aria-atomic="true"
aria-live="assertive"
class="swiper-notification"
/>
</div>
</div>
</div>
</DocumentFragment>
`;

exports[`Carousel renders correctly without navigation 1`] = `
<div
className="widget-carousel"
>
<DocumentFragment>
<div
className="swiper"
class="widget-carousel"
>
<ul
className="swiper-wrapper"
<div
class="swiper swiper-fade swiper-initialized swiper-horizontal swiper-watch-progress"
>
<li
aria-hidden={false}
className="swiper-slide"
id="carousel-slide-Carousel-1"
onLoad={[Function]}
<ul
aria-live="off"
class="swiper-wrapper"
id="swiper-wrapper-2222222222222222"
style="transition-duration: 0ms;"
>
<div>
test1
</div>
</li>
<li
aria-hidden={true}
className="swiper-slide"
id="carousel-slide-Carousel-2"
onLoad={[Function]}
<li
aria-hidden="false"
aria-label="1 / 2"
class="swiper-slide"
data-swiper-slide-index="0"
id="carousel-slide-Carousel-1"
role="listitem"
>
<div>
test1
</div>
</li>
<li
aria-hidden="true"
aria-label="2 / 2"
class="swiper-slide"
data-swiper-slide-index="1"
id="carousel-slide-Carousel-2"
role="listitem"
>
<div>
test2
</div>
</li>
</ul>
<div
class="swiper-pagination swiper-pagination-clickable swiper-pagination-bullets swiper-pagination-horizontal"
>
<div>
test2
</div>
</li>
</ul>
<div
className="swiper-pagination"
/>
<span
aria-controls="carousel-slide-Carousel-1"
aria-current="true"
aria-label="Go to slide 0"
class="swiper-pagination-bullet swiper-pagination-bullet-active"
role="button"
tabindex="0"
/>
<span
aria-controls="carousel-slide-Carousel-2"
aria-label="Go to slide 1"
class="swiper-pagination-bullet"
role="button"
tabindex="0"
/>
</div>
<span
aria-atomic="true"
aria-live="assertive"
class="swiper-notification"
/>
</div>
</div>
</div>
</DocumentFragment>
`;

exports[`Carousel renders correctly without pagination 1`] = `
<div
className="widget-carousel"
>
<DocumentFragment>
<div
className="swiper"
class="widget-carousel"
>
<ul
className="swiper-wrapper"
<div
class="swiper swiper-fade swiper-initialized swiper-horizontal swiper-watch-progress"
>
<li
aria-hidden={false}
className="swiper-slide"
id="carousel-slide-Carousel-1"
onLoad={[Function]}
>
<div>
test1
</div>
</li>
<li
aria-hidden={true}
className="swiper-slide"
id="carousel-slide-Carousel-2"
onLoad={[Function]}
<ul
aria-live="off"
class="swiper-wrapper"
id="swiper-wrapper-2222222222222222"
style="transition-duration: 0ms;"
>
<div>
test2
</div>
</li>
</ul>
<div
className="swiper-button-prev"
/>
<div
className="swiper-button-next"
/>
<li
aria-hidden="false"
aria-label="1 / 2"
class="swiper-slide"
data-swiper-slide-index="0"
id="carousel-slide-Carousel-1"
role="listitem"
>
<div>
test1
</div>
</li>
<li
aria-hidden="true"
aria-label="2 / 2"
class="swiper-slide"
data-swiper-slide-index="1"
id="carousel-slide-Carousel-2"
role="listitem"
>
<div>
test2
</div>
</li>
</ul>
<div
aria-controls="swiper-wrapper-2222222222222222"
aria-label="Previous slide"
class="swiper-button-prev"
role="button"
tabindex="0"
/>
<div
aria-controls="swiper-wrapper-2222222222222222"
aria-label="Next slide"
class="swiper-button-next"
role="button"
tabindex="0"
/>
<span
aria-atomic="true"
aria-live="assertive"
class="swiper-notification"
/>
</div>
</div>
</div>
</DocumentFragment>
`;
Loading
Loading