Skip to content

[WC-3037] RichText: Modal form orientation - #1811

Merged
yordan-st merged 5 commits into
mainfrom
feat/WC-3037_richtext-form-orientation
Sep 3, 2025
Merged

[WC-3037] RichText: Modal form orientation#1811
yordan-st merged 5 commits into
mainfrom
feat/WC-3037_richtext-form-orientation

Conversation

@yordan-st

@yordan-st yordan-st commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Pull request type

New feature (non-breaking change which adds functionality)


Description

Added support to configure the form orientation of modals, via the widget properties in Studio Pro.

Now Developers can configure this in the same way as this is done with regular TextBoxes in a DataView

What should be covered while testing?

  • Toggle 'vertical' or 'horizontal' orientation in the General tab, Editability section
  • Run app and check if this changed the orientation for add Link, Image and Video modals
  • Inspect if this correctly changed the classes to 'vertical' or 'horizontal'
  • Inspect if the 'for' and 'id' attributes of the labels and inputs correspond to eachother
  • Inspect if the DOM structure changes. Similar to regular TextBoxes in DataViews, the DOM should be different when toggling between orientations.

@yordan-st
yordan-st marked this pull request as ready for review August 6, 2025 13:34
@yordan-st
yordan-st requested a review from a team as a code owner August 6, 2025 13:34
@yordan-st yordan-st changed the title feat: add form orientation property to rich text modal dialogs and co… [WC-3037] Aug 6, 2025
@yordan-st yordan-st changed the title [WC-3037] [WC-3037] RichText: Modal form orientation Aug 6, 2025
Comment thread packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/Dialog.tsx Outdated
Comment thread packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/Dialog.tsx Outdated
Comment thread packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/Dialog.scss Outdated
@yordan-st
yordan-st force-pushed the feat/WC-3037_richtext-form-orientation branch from a4f60b5 to 9f49b5d Compare August 18, 2025 09:46
Comment thread packages/pluggableWidgets/rich-text-web/src/components/ModalDialog/LinkDialog.tsx Outdated
@yordan-st
yordan-st force-pushed the feat/WC-3037_richtext-form-orientation branch from 9f49b5d to 3811a8d Compare September 1, 2025 09:28
@yordan-st
yordan-st merged commit 71f6a22 into main Sep 3, 2025
14 checks passed
@yordan-st
yordan-st deleted the feat/WC-3037_richtext-form-orientation branch September 3, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants