diff --git a/packages/pluggableWidgets/datagrid-web/CHANGELOG.md b/packages/pluggableWidgets/datagrid-web/CHANGELOG.md index ae008be9a5..c1d4d1d131 100644 --- a/packages/pluggableWidgets/datagrid-web/CHANGELOG.md +++ b/packages/pluggableWidgets/datagrid-web/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## [Unreleased] +### Fixed + +- We fixed an issue where the datagrid's horizontal scrollbar would unexpectedly jump to the right when the column selector was enabled. + ## [3.3.0] - 2025-08-28 ### Added diff --git a/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx b/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx index 7d22f3d6c6..4280288500 100644 --- a/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx +++ b/packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx @@ -1,5 +1,13 @@ -import { autoUpdate, size, useClick, useDismiss, useFloating, useInteractions } from "@floating-ui/react"; -import { createElement, ReactElement, useEffect, useLayoutEffect, useMemo, useRef, useState } from "react"; +import { + autoUpdate, + FloatingFocusManager, + size, + useClick, + useDismiss, + useFloating, + useInteractions +} from "@floating-ui/react"; +import { createElement, ReactElement, useEffect, useMemo, useState } from "react"; import { flushSync } from "react-dom"; import { GridColumn } from "../typings/GridColumn"; import { FaEye } from "./icons/FaEye"; @@ -15,7 +23,6 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement { const { visibleLength } = props; const [show, setShow] = useState(false); const [maxHeight, setMaxHeight] = useState(0); - const buttonRef = useRef(null); const { refs, floatingStyles, context, update } = useFloating({ open: show, placement: "bottom-end", @@ -49,20 +56,6 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement { const firstHidableColumnIndex = useMemo(() => props.columns.findIndex(c => c.canHide), [props.columns]); const lastHidableColumnIndex = useMemo(() => props.columns.map(c => c.canHide).lastIndexOf(true), [props.columns]); - useLayoutEffect(() => { - if (show) { - // Focus the first visible column - setTimeout(() => { - (refs.floating?.current?.querySelector("li") as HTMLElement)?.focus(); - }, 10); - } else { - // focus back to the button when closing - setTimeout(() => { - (refs.reference?.current as HTMLElement)?.focus(); - }, 10); - } - }, [show]); - const optionsComponent = (