Skip to content

chore: remove language selector - #2288

Merged
r0b1n merged 1 commit into
mainfrom
chore/remove-language-selector
Jul 6, 2026
Merged

chore: remove language selector#2288
r0b1n merged 1 commit into
mainfrom
chore/remove-language-selector

Conversation

@r0b1n

@r0b1n r0b1n commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

This package is replaced by combobox in both version of atlas core.

@r0b1n
r0b1n requested a review from a team as a code owner June 23, 2026 11:31
iobuhov
iobuhov previously approved these changes Jun 23, 2026
View reviewed changes
@github-actions

This comment has been minimized.

Sign in to view
leonardomendix
leonardomendix previously approved these changes Jun 23, 2026
View reviewed changes
@r0b1n
r0b1n dismissed stale reviews from leonardomendix and iobuhov via 3597624 June 23, 2026 12:33
@r0b1n
r0b1n force-pushed the chore/remove-language-selector branch from 539afd2 to 3597624 Compare June 23, 2026 12:33
@github-actions

This comment has been minimized.

Sign in to view
leonardomendix
leonardomendix previously approved these changes Jun 23, 2026
View reviewed changes
@r0b1n
r0b1n force-pushed the chore/remove-language-selector branch from 3597624 to eb5c5ee Compare June 24, 2026 09:31
@github-actions

This comment has been minimized.

Sign in to view
@r0b1n
chore: this package is replaced with combobox
e905712 
# Conflicts:
#	pnpm-lock.yaml

# Conflicts:
#	pnpm-lock.yaml
@r0b1n
r0b1n force-pushed the chore/remove-language-selector branch from eb5c5ee to e905712 Compare July 6, 2026 13:24
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found

What was reviewed

File Change
.github/configs/labeler.yml Removed language-selector-web label entry
packages/pluggableWidgets/language-selector-web/** Full package deletion (all source, tests, E2E, config, typings, CHANGELOG, README, assets)
pnpm-lock.yaml Lockfile updated to reflect removed package dependencies

Skipped (out of scope): pnpm-lock.yaml (lockfile changes), dist/, snapshot PNGs

Positives

  • Complete and clean removal — no orphaned references left behind in .github/configs/labeler.yml, workflow configs, or other packages
  • Lockfile is consistent with the removed package.json, including the @floating-ui/react, classnames, and @mendix/widget-plugin-component-kit dependencies
  • PR description clearly states the migration rationale (replaced by combobox in Atlas core)
  • The original E2E spec correctly used @mendix/run-e2e/fixtures and waitForMendixApp — deleted cleanly

@r0b1n
r0b1n merged commit 550d25b into main Jul 6, 2026
11 of 12 checks passed
@r0b1n
r0b1n deleted the chore/remove-language-selector branch July 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelreichert samuelreichert samuelreichert approved these changes
@leonardomendix leonardomendix leonardomendix approved these changes
@iobuhov iobuhov iobuhov left review comments

Assignees

No one assigned

Labels

language-selector-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r0b1n @samuelreichert @iobuhov @leonardomendix