Skip to content

fix: scope mime-types patch to v2 only - #2309

Merged
r0b1n merged 1 commit into
mainfrom
fix/mime-types-patch-v2-only
Jul 6, 2026
Merged

fix: scope mime-types patch to v2 only#2309
r0b1n merged 1 commit into
mainfrom
fix/mime-types-patch-v2-only

Conversation

@r0b1n

@r0b1n r0b1n commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary: scope patched dependency to mime-types@2.1.35, rename patch file, and stop patching mime-types@3.x.

Limit pnpm patching to mime-types@2.1.35.
Remove the generic mime-types patch so mime-types@3.x stays unpatched.
@r0b1n
r0b1n requested a review from a team as a code owner July 6, 2026 14:12
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
package.json Scoped patchedDependencies key from bare mime-types to versioned mime-types@2.1.35
patches/mime-types@2.1.35.patch Renamed from patches/mime-types.patch (content unchanged)
pnpm-lock.yaml Removed patch_hash annotation from mime-types@3.0.2 snapshots; updated patch path reference

Skipped (out of scope): pnpm-lock.yaml lockfile-only lines beyond the patched-dep entries


Positives

  • The fix is minimal and surgical: only the version specifier and file name change; the patch content itself is untouched, so no risk of regressing the v2 fix.
  • Correctly identifies that mime-types@3.0.2 does not need the custom extname polyfill (v3 no longer depends on path in the same way) — all five mime-types@3.0.2 lockfile snapshots are consistently cleaned up.
  • No widget runtime code changed, so no CHANGELOG entry is needed.

@r0b1n
r0b1n merged commit 7d2003d into main Jul 6, 2026
13 of 15 checks passed
@r0b1n
r0b1n deleted the fix/mime-types-patch-v2-only branch July 6, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants