AI Code Review

⚠️ Approved with suggestions — low-severity items only, safe to merge

What was reviewed

Skipped (out of scope): dist/, pnpm-lock.yaml

All CI checks could not be fetched (approval required), so CI status is unverified.

Findings

⚠️ Low — imageButton helper relies on [role='button'] — fragile if the widget renders a native <button>

File: packages/pluggableWidgets/image-web/e2e/onClick.spec.js line 8
Note: The helper page.locator(${widgetClass} [role='button']) will miss a native <button> element (which has the implicit role but is not matched by an explicit [role='button'] attribute selector in all Playwright versions). If the Image widget's clickable element ever changes from a role="button" <div>/<span> to a proper <button> tag, this selector silently stops matching. Consider using getByRole("button") scoped to the widget container for a more resilient selector:

const imageButton = (page, widgetClass) =>
    page.locator(widgetClass).getByRole("button");

This is non-blocking — the current tests pass today — but it's worth noting for future-proofing.

Positives

• Removing await from page.locator(...) calls is the correct Playwright pattern — locators are lazy and the await was misleading.
• Adding await expect(modalDialog).toBeVisible() before .toContainText() is a concrete improvement: the assertion now waits for the dialog to appear rather than racing against it.
• CHANGELOG entry is user-facing and correctly scoped to behavior, not implementation details.
• PR description clearly explains why existing widgets are unaffected (Mendix only applies XML defaults on first drop), which is accurate and helpful context for reviewers.