Skip to content

[WC-3471]: fix(image-web): migrate image source properties to allowUpload - #2354

Open
yordan-st wants to merge 6 commits into
mainfrom
feat/WC-3471_image-allowupload
Open

[WC-3471]: fix(image-web): migrate image source properties to allowUpload#2354
yordan-st wants to merge 6 commits into
mainfrom
feat/WC-3471_image-allowupload

Conversation

@yordan-st

Copy link
Copy Markdown
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

imageObject and defaultImageDynamic in the Image widget were declared as type="image" without allowUpload, which Mendix has deprecated — DynamicValue<WebImage> is removed in Mendix 12, and Studio Pro 11.8+ already shows a design-time deprecation warning for this pattern.

This adds allowUpload="true" to both properties and regenerates typings accordingly (EditableImageValue<WebImage>). The widget's read logic in Image.tsx is unchanged — EditableImageValue exposes the same status/value.uri shape the widget already consumes, so this is a display-only migration with no new upload UI.

marketplace.minimumMXVersion is bumped to 11.12.0 since the widget XML now requires allowUpload support, which older Studio Pro versions cannot parse (verified: Studio Pro <11.8 fails to load the widget package with "The 'allowUpload' attribute is not declared").

Manually verified in Studio Pro 11.12 that both Static and Dynamic image-source configuration remain available in the property editor after this change — existing apps using a static image are not broken.

Widget version is not bumped in this PR (bumped at release time per repo convention); this change will require a major bump (2.0.0) on release due to the minimumMXVersion increase.

What should be covered while testing?

  • Existing Image widget configurations (static image, dynamic/attribute-bound image, icon, image URL datasources) continue to render identically.
  • No upload/file-picker UI appears anywhere on the widget.
  • Widget can be added to a page in Studio Pro 11.12+; "Image source" and "Default image" properties still offer both Static and Dynamic configuration.

@yordan-st
yordan-st requested a review from a team as a code owner July 23, 2026 13:50
@github-actions

This comment has been minimized.

Comment thread packages/pluggableWidgets/image-web/src/__tests__/Image.spec.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants