Fix linting and formatting issues

Author: weirdwater

eslint.config.js

@@ -7,20 +7,17 @@ import prettierRecommended from "eslint-plugin-prettier/recommended";
 
 export default defineConfig([
   {
-    files: [
-      "**/*.js",
-      "**/*.mjs"
-    ],
+    files: ["**/*.js", "**/*.mjs"],
     ignores: [
       "packages/generator-widget/generators/app/templates/**",
       "packages/release-tools/utils/changelog-parser/changelog.js",
-      "packages/pluggable-widgets-tools/dist/**",
+      "packages/pluggable-widgets-tools/dist/**"
     ],
     plugins: { js },
     extends: ["js/recommended"],
     languageOptions: { globals: globals.node },
     rules: {
-      "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
+      "no-unused-vars": ["error", { argsIgnorePattern: "^_" }]
     }
   },
   {
@@ -34,13 +31,9 @@ export default defineConfig([
     }
   },
   {
-    files: [
-      "**/__mocks__/**/*.js",
-      "**/__tests__/**/*.js",
-      "packages/pluggable-widgets-tools/test-config/**",
-    ],
+    files: ["**/__mocks__/**/*.js", "**/__tests__/**/*.js", "packages/pluggable-widgets-tools/test-config/**"],
     plugins: { jest },
     languageOptions: { globals: jest.environments.globals.globals }
   },
-  prettierRecommended,
+  prettierRecommended
 ]);

packages/generator-widget/bin.js

@@ -12,6 +12,4 @@ const env = createEnv();
 env.register(join(__dirname, "./generators/app/index.js"), "@mendix/widget");
 
 const args = process.argv.slice(2);
-env.run(['@mendix/widget', ...args].join(" "))
-
-
+env.run(["@mendix/widget", ...args].join(" "));

packages/generator-widget/generators/app/index.js

@@ -244,15 +244,8 @@ class MxGenerator extends Generator {
     }
 
     _copyTemplate(source, destination, replaceVariable = this.widget) {
-        this.fs.copyTpl(
-            this.templatePath(source),
-            this.destinationPath(destination),
-            replaceVariable,
-            {},
-            {}
-        );
+        this.fs.copyTpl(this.templatePath(source), this.destinationPath(destination), replaceVariable, {}, {});
     }
 }
 
-
 export default MxGenerator;

packages/pluggable-widgets-tools/bin/mx-scripts.js

@@ -13,10 +13,9 @@ checkNodeVersion();
     try {
         await checkMigration();
     } catch (e) {
-        console.log(red("An error occurred while checking migration dependencies"));
+        console.log(red("An error occurred while checking migration dependencies: %s"), e);
     }
 
-
     const [, currentScriptPath, cmd, ...args] = process.argv;
     const toolsRoot = currentScriptPath.endsWith("pluggable-widgets-tools")
         ? join(dirname(currentScriptPath), "../@mendix/pluggable-widgets-tools")
@@ -54,7 +53,7 @@ checkNodeVersion();
                 // Hack for Windows using NTFS Filesystem, we cannot add platform specific check otherwise GitBash or other linux based terminal on windows will also fail.
                 Path: [process.env.Path].concat(nodeModulesBins).join(delimiter),
                 // ESLint 9 compatibility: use legacy config format until flat config migration is complete
-                ESLINT_USE_FLAT_CONFIG: "false",
+                ESLINT_USE_FLAT_CONFIG: "false"
             },
             shell: true,
             stdio: "inherit"
@@ -158,19 +157,19 @@ function checkNodeVersion() {
         if (!nodeRange.test(nodeVersion)) {
             console.error(
                 red(`To build this widget a minimum node version ${nodeRange} is required.\n`) +
-                bold(whiteBright("Please upgrade your node version!"))
+                    bold(whiteBright("Please upgrade your node version!"))
             );
             process.exit(1);
         }
         if (npmVersion < 8) {
             console.error(
                 red("To build this widget a minimum npm version 8.0.0 is required.\n") +
-                bold(whiteBright("Please upgrade your npm version!"))
+                    bold(whiteBright("Please upgrade your npm version!"))
             );
             process.exit(1);
         }
     } catch (e) {
-        throw new Error("Cannot find node or npm to determine the version:" + e);
+        throw new Error("Cannot find node or npm to determine the version", { cause: e });
     }
 }
 

packages/pluggable-widgets-tools/configs/helpers/rollup-helper.mjs

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-
 import { existsSync, mkdirSync } from "fs";
 import { join } from "path";
 import fg from "fast-glob";

packages/pluggable-widgets-tools/configs/rollup-plugin-collect-dependencies.mjs

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-
 import fg from "fast-glob";
 import fsExtra from "fs-extra";
 import { existsSync, readFileSync, writeFileSync } from "fs";

packages/pluggable-widgets-tools/configs/rollup.config.mjs

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-
 import { existsSync } from "node:fs";
 import { join } from "node:path";
 import { fileURLToPath } from "node:url";
@@ -122,7 +120,7 @@ export default async args => {
                 postCssPlugin(outputFormat, production),
                 alias({
                     entries: {
-                        "react-hot-loader/root": fileURLToPath(new URL("hot", import.meta.url)),
+                        "react-hot-loader/root": fileURLToPath(new URL("hot", import.meta.url))
                     }
                 }),
                 ...getCommonPlugins({
@@ -199,7 +197,7 @@ export default async args => {
                             setTimeout(() => process.exit(0));
                         }
                     },
-                    name: 'force-close'
+                    name: "force-close"
                 }
             ],
             onwarn: onwarn(args)
@@ -208,10 +206,11 @@ export default async args => {
 
     const customConfigPathJS = join(sourcePath, "rollup.config.js");
     const customConfigPathESM = join(sourcePath, "rollup.config.mjs");
-    const existingConfigPath =
-        existsSync(customConfigPathJS) ? customConfigPathJS
-            : existsSync(customConfigPathESM) ? customConfigPathESM
-                : null;
+    const existingConfigPath = existsSync(customConfigPathJS)
+        ? customConfigPathJS
+        : existsSync(customConfigPathESM)
+          ? customConfigPathESM
+          : null;
     if (existingConfigPath != null) {
         const customConfig = await loadConfigFile(existingConfigPath, { ...args, configDefaultConfig: result });
         customConfig.warnings.flush();
@@ -225,12 +224,12 @@ export default async args => {
             nodeResolve({ preferBuiltins: false, mainFields: ["module", "browser", "main"] }),
             isTypescript
                 ? typescript({
-                    noEmitOnError: !args.watch,
-                    sourceMap: config.sourceMaps,
-                    inlineSources: config.sourceMaps,
-                    target: "es2022", // we transpile the result with babel anyway, see below
-                    exclude: ["**/__tests__/**/*"]
-                })
+                      noEmitOnError: !args.watch,
+                      sourceMap: config.sourceMaps,
+                      inlineSources: config.sourceMaps,
+                      target: "es2022", // we transpile the result with babel anyway, see below
+                      exclude: ["**/__tests__/**/*"]
+                  })
                 : null,
             // Babel can transpile source JS and resulting JS, hence are input/output plugins. The good
             // practice is to do the most of conversions on resulting code, since then we ensure that
@@ -267,29 +266,29 @@ export default async args => {
             }),
             config.transpile
                 ? getBabelOutputPlugin({
-                    sourceMaps: config.sourceMaps,
-                    babelrc: false,
-                    compact: false,
-                    ...(config.babelConfig || {})
-                })
+                      sourceMaps: config.sourceMaps,
+                      babelrc: false,
+                      compact: false,
+                      ...(config.babelConfig || {})
+                  })
                 : null,
             image(),
             production ? terser() : null,
             config.licenses
                 ? license({
-                    thirdParty: {
-                        includePrivate: true,
-                        output: [
-                            {
-                                file: join(outDir, "dependencies.txt")
-                            },
-                            {
-                                file: join(outDir, "dependencies.json"),
-                                template: licenseCustomTemplate
-                            }
-                        ]
-                    }
-                })
+                      thirdParty: {
+                          includePrivate: true,
+                          output: [
+                              {
+                                  file: join(outDir, "dependencies.txt")
+                              },
+                              {
+                                  file: join(outDir, "dependencies.json"),
+                                  template: licenseCustomTemplate
+                              }
+                          ]
+                      }
+                  })
                 : null,
             // We need to create .mpk and copy results to test project after bundling is finished.
             // In case of a regular build is it is on `writeBundle` of the last config we define

packages/pluggable-widgets-tools/configs/rollup.config.native.mjs

@@ -1,7 +1,5 @@
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-
 import { existsSync } from "fs";
-import { join, relative } from "path";
+import { join } from "path";
 import { getBabelInputPlugin, getBabelOutputPlugin } from "@rollup/plugin-babel";
 import commonjs from "@rollup/plugin-commonjs";
 import image from "@rollup/plugin-image";
@@ -105,20 +103,20 @@ export default async args => {
                     widgetName,
                     ...(production && i === 0
                         ? {
-                            licenseOptions: {
-                                thirdParty: {
-                                    output: [
-                                        {
-                                            file: join(outDir, "dependencies.txt")
-                                        },
-                                        {
-                                            file: join(outDir, "dependencies.json"),
-                                            template: licenseCustomTemplate
-                                        }
-                                    ]
-                                }
-                            }
-                        }
+                              licenseOptions: {
+                                  thirdParty: {
+                                      output: [
+                                          {
+                                              file: join(outDir, "dependencies.txt")
+                                          },
+                                          {
+                                              file: join(outDir, "dependencies.json"),
+                                              template: licenseCustomTemplate
+                                          }
+                                      ]
+                                  }
+                              }
+                          }
                         : null)
                 }),
                 ...getCommonPlugins({
@@ -165,10 +163,11 @@ export default async args => {
 
     const customConfigPathJS = join(sourcePath, "rollup.config.js");
     const customConfigPathESM = join(sourcePath, "rollup.config.mjs");
-    const existingConfigPath =
-        existsSync(customConfigPathJS) ? customConfigPathJS
-            : existsSync(customConfigPathESM) ? customConfigPathESM
-                : null;
+    const existingConfigPath = existsSync(customConfigPathJS)
+        ? customConfigPathJS
+        : existsSync(customConfigPathESM)
+          ? customConfigPathESM
+          : null;
     if (existingConfigPath != null) {
         const customConfig = await loadConfigFile(existingConfigPath, { ...args, configDefaultConfig: result });
         customConfig.warnings.flush();
@@ -182,12 +181,12 @@ export default async args => {
             nodeResolve({ preferBuiltins: false, mainFields: ["module", "browser", "main"] }),
             isTypescript
                 ? typescript({
-                    noEmitOnError: !args.watch,
-                    sourceMap: config.sourceMaps,
-                    inlineSources: config.sourceMaps,
-                    target: "es2022", // we transpile the result with babel anyway, see below
-                    exclude: ["**/__tests__/**/*"]
-                })
+                      noEmitOnError: !args.watch,
+                      sourceMap: config.sourceMaps,
+                      inlineSources: config.sourceMaps,
+                      target: "es2022", // we transpile the result with babel anyway, see below
+                      exclude: ["**/__tests__/**/*"]
+                  })
                 : null,
             // Babel can transpile source JS and resulting JS, hence are input/output plugins. The good
             // practice is to do the most of conversions on resulting code, since then we ensure that
@@ -224,11 +223,11 @@ export default async args => {
             }),
             config.transpile
                 ? getBabelOutputPlugin({
-                    sourceMaps: config.sourceMaps,
-                    babelrc: false,
-                    compact: false,
-                    ...(config.babelConfig || {})
-                })
+                      sourceMaps: config.sourceMaps,
+                      babelrc: false,
+                      compact: false,
+                      ...(config.babelConfig || {})
+                  })
                 : null,
             image(),
             production ? terser({ mangle: false }) : null,

packages/pluggable-widgets-tools/configs/shared.mjs

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/explicit-function-return-type */
-
 import { existsSync, readdirSync, promises as fs, readFileSync } from "node:fs";
 import { join, relative } from "node:path";
 import { config } from "dotenv";
@@ -18,17 +16,17 @@ export async function listDir(path) {
 
 export const sourcePath = process.cwd();
 
-const widgetPackageJson = JSON.parse(readFileSync(join(sourcePath, "package.json")))
+const widgetPackageJson = JSON.parse(readFileSync(join(sourcePath, "package.json")));
 export const widgetName = widgetPackageJson.widgetName;
 export const widgetPackage = widgetPackageJson.packagePath;
 export const widgetVersion = widgetPackageJson.version;
 if (!widgetName || !widgetPackageJson) {
     throw new Error("Widget does not define widgetName in its package.json");
 }
 
-throwOnIllegalChars(widgetName, "a-zA-Z", "The `widgetName` property in package.json")
-throwOnIllegalChars(widgetPackage, "a-zA-Z0-9_.-", "The `packagePath` property in package.json")
-throwOnNoMatch(widgetPackage, /^([a-zA-Z0-9_-]+.)*[a-zA-Z0-9_-]+$/, "The `packagePath` property in package.json")
+throwOnIllegalChars(widgetName, "a-zA-Z", "The `widgetName` property in package.json");
+throwOnIllegalChars(widgetPackage, "a-zA-Z0-9_.-", "The `packagePath` property in package.json");
+throwOnNoMatch(widgetPackage, /^([a-zA-Z0-9_-]+.)*[a-zA-Z0-9_-]+$/, "The `packagePath` property in package.json");
 
 const widgetSrcFiles = readdirSync(join(sourcePath, "src")).map(file => join(sourcePath, "src", file));
 export const widgetEntry = widgetSrcFiles.filter(file =>
@@ -53,7 +51,7 @@ export const projectPath = [
     join(sourcePath, "tests/testProject")
 ].filter(path => path && existsSync(path))[0];
 
-export const onwarn = (args) => (warning, warn) => {
+export const onwarn = args => (warning, warn) => {
     // Module level directives is ignored by Rollup since it causes error when bundled.
     // And to not pollute the terminal, the warning code "MODULE_LEVEL_DIRECTIVE" and "SOURCEMAP_ERROR"
     // should be ignored and handled separetely from the safe warning list.
@@ -68,17 +66,14 @@ export const onwarn = (args) => (warning, warn) => {
 
     const error =
         (warning.plugin ? `(${warning.plugin} plugin) ` : "") +
-        (warning.loc
-            ? `${relative(sourcePath, warning.loc.file)} (${warning.loc.line}:${warning.loc.column}) `
-            : "") +
+        (warning.loc ? `${relative(sourcePath, warning.loc.file)} (${warning.loc.line}:${warning.loc.column}) ` : "") +
         `Error: ${warning.message}` +
         (warning.frame ? warning.frame : "");
 
     console.error(colors.red(error));
     process.exit(1);
-}
+};
 
 function escape(str) {
     return str.replace(/([.?*+^$[\]\\(){}|-])/g, "\\$1");
 }
-