Skip to content

Commit 869952b

Browse files
authored
[WTF-2693]: Re-enable test command in command tests (#183)
The command tests had the unit tests commented out. This PR re-enables them. As the checks passed, it seems that the previous issues are no longer present.
2 parents d60b3eb + 9700a0e commit 869952b

3 files changed

Lines changed: 7 additions & 16 deletions

File tree

packages/command-tests/commands.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ async function main() {
120120
await testLint();
121121

122122
// Temporarily disabled due to bizarre typing issues in the CI that cannot be reproduced in any local environment
123-
// logger(`Testing unit tests....`);
124-
// await testTest();
123+
logger(`Testing unit tests....`);
124+
await testTest();
125125

126126
if (LIMIT_TESTS) {
127127
logger(`Quick tested!`);
@@ -131,10 +131,6 @@ async function main() {
131131
logger(`Testing 'build' command...`);
132132
await testBuild();
133133

134-
// Temporarily disabled due to bizarre typing issues in the CI that cannot be reproduced in any local environment
135-
// logger(`Testing 'test:unit' command...`);
136-
// await testTestUnit();
137-
138134
logger(`Testing 'release' command...`);
139135
await testRelease();
140136

@@ -211,7 +207,6 @@ async function main() {
211207
await execAsync("npm run lint", workDir, logger);
212208
}
213209

214-
// eslint-disable-next-line no-unused-vars
215210
async function testTest() {
216211
if (platform === "native") {
217212
await execFailedAsync("npm test -- --forceExit", workDir);
@@ -235,14 +230,6 @@ async function main() {
235230
}
236231
}
237232

238-
// eslint-disable-next-line no-unused-vars
239-
async function testTestUnit() {
240-
await execAsync("npm run test:unit -- --forceExit", workDir, logger);
241-
if (!existsSync(join(workDir, `/dist/coverage/clover.xml`))) {
242-
throw new Error("Expected coverage file to be generated, but it wasn't.");
243-
}
244-
}
245-
246233
async function testRelease() {
247234
rm("-rf", join(workDir, "dist"));
248235
await execAsync("npm run release", workDir, logger);

packages/generator-widget/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Changed
10+
11+
- We cleaned up a template with unused imports.
12+
913
## [11.11.0] - 2026-06-04
1014

1115
### Changed

packages/generator-widget/generators/app/templates/pluggable/web/fullTemplateTs/src/components/__tests__/Alert.spec.tsx.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { render, screen } from "@testing-library/react";
1+
import { render } from "@testing-library/react";
22
import "@testing-library/jest-dom";
33

44
import { Alert } from "../Alert";

0 commit comments

Comments
 (0)