[WTF-2697]: Widget Bundler 11.11.0 does not copy (all) files on windows (#185)

Checklist
Contains unit tests ✅
Contains breaking changes ❌
Compatible with: MX 9️⃣ (11.x)
Did you update version and changelog? ✅ changelog / ❌ version
PR title properly formatted? ✅
This PR contains
 Bug fix
What is the purpose of this PR?
Fix Windows builds producing an .mpk missing the widget's .xml files and
icon/tile PNGs.

Relevant changes
The copy step used absolute drive-letter globs that fast-glob returns
empty for on Windows, so the widget files were silently skipped;
switched both rollup configs to relative globs and added an assertion in
command-tests so an incomplete .mpk

What should be covered while testing?
Build on Windows and Linux; confirm the .mpk contains package.xml and
.xml (and PNGs when present in src).

Author: weirdwater

packages/command-tests/commands.js

@@ -218,31 +218,31 @@ async function main() {
 
         async function testBuild() {
             await execAsync("npm run build", workDir, logger);
-            if (
-                !existsSync(
-                    join(
-                        workDir,
-                        `/dist/${widgetPackageJson.version}/${widgetPackageJson.packagePath}.${widgetPackageJson.widgetName}.mpk`
-                    )
-                )
-            ) {
-                throw new Error("Expected mpk file to be generated, but it wasn't.");
-            }
+            checkWidgetBundleFiles();
         }
 
         async function testRelease() {
             rm("-rf", join(workDir, "dist"));
             await execAsync("npm run release", workDir, logger);
+            checkWidgetBundleFiles();
+        }
 
-            if (
-                !existsSync(
-                    join(
-                        workDir,
-                        `/dist/${widgetPackageJson.version}/${widgetPackageJson.packagePath}.${widgetPackageJson.widgetName}.mpk`
-                    )
-                )
-            ) {
-                throw new Error("Expected mpk file to be generated, but it wasn't.");
+        function checkWidgetBundleFiles() {
+            const stagingDir = join(workDir, "dist", "tmp", "widgets");
+            const mpkFile = join(
+                workDir,
+                "dist",
+                widgetPackageJson.version,
+                `${widgetPackageJson.packagePath}.${widgetPackageJson.widgetName}.mpk`
+            );
+            const requiredFiles = [
+                mpkFile,
+                join(stagingDir, "package.xml"),
+                join(stagingDir, `${widgetPackageJson.widgetName}.xml`)
+            ];
+            const missing = requiredFiles.filter(f => !existsSync(f));
+            if (missing.length) {
+                throw new Error(`Expected widget bundle files in mpk, but missing: ${missing.join(", ")}.`);
             }
         }
 

packages/pluggable-widgets-tools/CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+-   We fixed an issue on Windows where the generated `.mpk` was missing the widget's `.xml` files and icon/tile PNGs.
+
 ### Changed
 
 -   We replaced `ts-jest` with `@swc/jest` as the Jest transform (3–5× faster for TSX-heavy test suites) and switched the test runner from `jest-jasmine2` to `jest-circus`.

packages/pluggable-widgets-tools/configs/rollup.config.mjs

@@ -320,9 +320,9 @@ export default async args => {
             clear({ targets: [outDir, mpkDir] }),
             command([
                 () => {
-                    cp(join(sourcePath, "src/**/*.xml"), outDir);
+                    cp("src/**/*.xml", outDir);
                     if (existsSync(`src/${widgetName}.icon.png`) || existsSync(`src/${widgetName}.tile.png`)) {
-                        cp(join(sourcePath, `src/${widgetName}.@(tile|icon)?(.dark).png`), outDir);
+                        cp(`src/${widgetName}.@(tile|icon)?(.dark).png`, outDir);
                     }
                 }
             ]),

packages/pluggable-widgets-tools/configs/rollup.config.native.mjs

@@ -257,9 +257,9 @@ export default async args => {
             clear({ targets: [outDir, mpkDir] }),
             command([
                 () => {
-                    cp(join(sourcePath, "src/**/*.xml"), outDir);
+                    cp("src/**/*.xml", outDir);
                     if (existsSync(`src/${widgetName}.icon.png`) || existsSync(`src/${widgetName}.tile.png`)) {
-                        cp(join(sourcePath, `src/${widgetName}.@(tile|icon)?(.dark).png`), outDir);
+                        cp(`src/${widgetName}.@(tile|icon)?(.dark).png`, outDir);
                     }
                 }
             ])