[WTF-2349]: Migrate widget-tools repo to pnpm#132
Conversation
With pnpm overrides are managed from the repo root. As overrides only affect the project you are working in, they do not affect widgets that use the pluggable-widgets-tools.
c93b22b to
85e1a9c
Compare
|
Merge? |
|
Waiting for a second team approval, but capacity has been low in the last two weeks |
|
QA: When running |
Good catch, I only tested widgets with npm as my goal was to perform the migration without affecting consumers of the PWT. I was able to reproduce your issue with the latest version of the PWT on npm, so this is already the case for existing users using pnpm. To work around the error you must install npx @mendix/generator-widget@latest widget
cd widget
rm -rf node_modules
pnpm install
pnpm build
# The build will fail at this point.
#👇🏻 To fix it, install missing dependencies
pnpm add -D @types/jest @types/node @types/react
pnpm build # This will succeedThe root cause is the difference in strategy between npm and pnpm with respect to structuring the Considering this is the current behavior of the PWT I would like to proceed with this PR and suggest we address this annoyance in a future story. |
A few dependencies slipped through the cracks when migrating to pnpm: #132
This PR contains
What is the purpose of this PR?
Pnpm is an alternative package manager that has leaves a smaller footprint when installing dependencies. It also has great workspaces support which makes it easer to depend on other projects in the same monorepo as well as synchronizing dependencies between them. Another benefit is that other teams at Mendix use it to manage monorepos, so this move unifies our way of working.
Relevant changes
What should be covered while testing?