bug fix UTF-8 refactor: simplify capitalizeFirstRune using unicode.ToUpper. Replace strings.ToUpper roundtrip with direct unicode.ToUpper call for cleaner single-rune capitalization.

peterjumpnl · peterjumpnl · commit 20dc4e4c7c9d · 2026-04-02T11:31:03.000+02:00
diff --git a/mdl/executor/cmd_jsonstructures.go b/mdl/executor/cmd_jsonstructures.go
@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"io"
 	"strings"
+	"unicode"
 
 	"github.com/mendixlabs/mxcli/mdl/ast"
 	"github.com/mendixlabs/mxcli/sdk/mpr"
@@ -184,7 +185,7 @@ func capitalizeFirstRune(s string) string {
 		return s
 	}
 	runes := []rune(s)
-	runes[0] = rune(strings.ToUpper(string(runes[0]))[0])
+	runes[0] = unicode.ToUpper(runes[0])
 	return string(runes)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ import (`
`7`	`7`	`"fmt"`
`8`	`8`	`"io"`
`9`	`9`	`"strings"`
	`10`	`+ "unicode"`
`10`	`11`
`11`	`12`	`"github.com/mendixlabs/mxcli/mdl/ast"`
`12`	`13`	`"github.com/mendixlabs/mxcli/sdk/mpr"`
`@@ -184,7 +185,7 @@ func capitalizeFirstRune(s string) string {`
`184`	`185`	`return s`
`185`	`186`	`}`
`186`	`187`	`runes := []rune(s)`
`187`		`- runes[0] = rune(strings.ToUpper(string(runes[0]))[0])`
	`188`	`+ runes[0] = unicode.ToUpper(runes[0])`
`188`	`189`	`return string(runes)`
`189`	`190`	`}`
`190`	`191`