fix: repair remaining lowercase convention regressions

ako · claude · ako · commit 2c7640c29986 · 2026-04-21T16:12:28.000Z
More ToUpper-with-lowercase-cases bugs and hardcoded uppercase strings:

- Workflow properties: visitor hardcoded "DISPLAY", "EXPORT_LEVEL" etc. but
  mutator case values were already lowercase. Normalized all property strings
  (both hardcoded in visitor and remaining uppercase cases in mutator) to
  lowercase. Updated tests accordingly.

- Settings executor: strings.ToUpper(stmt.Section) with lowercase case values.
  Changed to ToLower; fixed "LANGUAGE" case and hardcoded "CONSTANT"/
  "CONFIGURATION" in visitor. Fixed MDL example (alter settings LANGUAGE).

- Entity event handlers: describe output used ToUpper for moment/event name.
  Changed to ToLower so output is "on before commit" not "on BEFORE COMMIT".

- REST client: method stored as BSON title case ("Get"), describe output needs
  strings.ToLower to produce "get" not "Get".

- Design properties: ON/OFF toggle values hardcoded as "ON"/"OFF" in visitor
  but switch used ToUpper with lowercase "on"/"off" cases. Fixed visitor to
  produce lowercase and switch to use ToLower.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/mdl-examples/doctype-tests/14-project-settings-examples.mdl b/mdl-examples/doctype-tests/14-project-settings-examples.mdl
@@ -124,7 +124,7 @@ drop configuration 'Staging';
 /**
  * Example 4.1: Set default language
  */
-alter settings LANGUAGE DefaultLanguageCode = 'en_US';
+alter settings language DefaultLanguageCode = 'en_US';
 
 /**
  * Example 4.2: Configure workflow settings
diff --git a/mdl/backend/mpr/workflow_mutator.go b/mdl/backend/mpr/workflow_mutator.go
@@ -85,11 +85,11 @@ func (m *mprWorkflowMutator) SetProperty(prop string, value string) error {
 		}
 		return nil
 
-	case "EXPORT_LEVEL":
+	case "export_level":
 		dSet(m.rawData, "ExportLevel", value)
 		return nil
 
-	case "DUE_DATE":
+	case "due_date":
 		dSet(m.rawData, "DueDate", value)
 		return nil
 
@@ -100,7 +100,7 @@ func (m *mprWorkflowMutator) SetProperty(prop string, value string) error {
 
 func (m *mprWorkflowMutator) SetPropertyWithEntity(prop string, value string, entity string) error {
 	switch prop {
-	case "OVERVIEW_PAGE":
+	case "overview_page":
 		if value == "" {
 			dSet(m.rawData, "AdminPage", nil)
 		} else {
@@ -180,7 +180,7 @@ func (m *mprWorkflowMutator) SetActivityProperty(activityRef string, atPos int,
 		}
 		return nil
 
-	case "TARGETING_MICROFLOW":
+	case "targeting_microflow":
 		userTargeting := bson.D{
 			{Key: "$ID", Value: bsonutil.NewIDBsonBinary()},
 			{Key: "$Type", Value: "Workflows$MicroflowUserTargeting"},
@@ -189,7 +189,7 @@ func (m *mprWorkflowMutator) SetActivityProperty(activityRef string, atPos int,
 		dSet(actDoc, "UserTargeting", userTargeting)
 		return nil
 
-	case "TARGETING_XPATH":
+	case "targeting_xpath":
 		userTargeting := bson.D{
 			{Key: "$ID", Value: bsonutil.NewIDBsonBinary()},
 			{Key: "$Type", Value: "Workflows$XPathUserTargeting"},
@@ -198,7 +198,7 @@ func (m *mprWorkflowMutator) SetActivityProperty(activityRef string, atPos int,
 		dSet(actDoc, "UserTargeting", userTargeting)
 		return nil
 
-	case "DUE_DATE":
+	case "due_date":
 		dSet(actDoc, "DueDate", value)
 		return nil
 
diff --git a/mdl/backend/mpr/workflow_mutator_test.go b/mdl/backend/mpr/workflow_mutator_test.go
@@ -183,7 +183,7 @@ func TestWorkflowMutator_SetProperty_ExportLevel(t *testing.T) {
 	doc = append(doc, bson.E{Key: "ExportLevel", Value: "Usable"})
 	m := newMutator(doc)
 
-	if err := m.SetProperty("EXPORT_LEVEL", "Hidden"); err != nil {
+	if err := m.SetProperty("export_level", "Hidden"); err != nil {
 		t.Fatalf("SetProperty EXPORT_LEVEL failed: %v", err)
 	}
 	if got := dGetString(m.rawData, "ExportLevel"); got != "Hidden" {
@@ -436,7 +436,7 @@ func TestWorkflowMutator_SetActivityProperty_DueDate(t *testing.T) {
 	act = append(act, bson.E{Key: "DueDate", Value: ""})
 	m := newMutator(makeWorkflowDoc(act))
 
-	if err := m.SetActivityProperty("Review", 0, "DUE_DATE", "${PT48H}"); err != nil {
+	if err := m.SetActivityProperty("Review", 0, "due_date", "${PT48H}"); err != nil {
 		t.Fatalf("SetActivityProperty DUE_DATE failed: %v", err)
 	}
 
@@ -1220,7 +1220,7 @@ func TestWorkflowMutator_SetActivityProperty_TargetingMicroflow(t *testing.T) {
 	act = append(act, bson.E{Key: "UserTargeting", Value: nil})
 	m := newMutator(makeWorkflowDoc(act))
 
-	if err := m.SetActivityProperty("Review", 0, "TARGETING_MICROFLOW", "MyModule.AssignReviewer"); err != nil {
+	if err := m.SetActivityProperty("Review", 0, "targeting_microflow", "MyModule.AssignReviewer"); err != nil {
 		t.Fatalf("SetActivityProperty TARGETING_MICROFLOW failed: %v", err)
 	}
 
@@ -1242,7 +1242,7 @@ func TestWorkflowMutator_SetActivityProperty_TargetingXPath(t *testing.T) {
 	act = append(act, bson.E{Key: "UserTargeting", Value: nil})
 	m := newMutator(makeWorkflowDoc(act))
 
-	if err := m.SetActivityProperty("Review", 0, "TARGETING_XPATH", "[Role = 'Admin']"); err != nil {
+	if err := m.SetActivityProperty("Review", 0, "targeting_xpath", "[Role = 'Admin']"); err != nil {
 		t.Fatalf("SetActivityProperty TARGETING_XPATH failed: %v", err)
 	}
 
@@ -1265,7 +1265,7 @@ func TestWorkflowMutator_SetPropertyWithEntity_OverviewPage(t *testing.T) {
 	doc = append(doc, bson.E{Key: "AdminPage", Value: nil})
 	m := newMutator(doc)
 
-	if err := m.SetPropertyWithEntity("OVERVIEW_PAGE", "MyModule.OverviewPage", ""); err != nil {
+	if err := m.SetPropertyWithEntity("overview_page", "MyModule.OverviewPage", ""); err != nil {
 		t.Fatalf("SetPropertyWithEntity OVERVIEW_PAGE failed: %v", err)
 	}
 
@@ -1285,7 +1285,7 @@ func TestWorkflowMutator_SetPropertyWithEntity_OverviewPage_Clear(t *testing.T)
 	}})
 	m := newMutator(doc)
 
-	if err := m.SetPropertyWithEntity("OVERVIEW_PAGE", "", ""); err != nil {
+	if err := m.SetPropertyWithEntity("overview_page", "", ""); err != nil {
 		t.Fatalf("SetPropertyWithEntity clear failed: %v", err)
 	}
 
diff --git a/mdl/executor/cmd_entities_describe.go b/mdl/executor/cmd_entities_describe.go
@@ -402,12 +402,7 @@ func describeEntity(ctx *ExecContext, name ast.QualifiedName) error {
 				if mfName == "" {
 					continue
 				}
-				eventName := string(eh.Event)
-				if eventName == "RollBack" {
-					eventName = "rollback"
-				} else {
-					eventName = strings.ToUpper(eventName)
-				}
+				eventName := strings.ToLower(string(eh.Event))
 				// Show parameter: ($currentObject) or ()
 				paramStr := "()"
 				if eh.PassEventObject {
@@ -419,7 +414,7 @@ func describeEntity(ctx *ExecContext, name ast.QualifiedName) error {
 					options = " raise error"
 				}
 				fmt.Fprintf(ctx.Output, "\non %s %s call %s%s%s",
-					strings.ToUpper(string(eh.Moment)), eventName, mfName, paramStr, options)
+					strings.ToLower(string(eh.Moment)), eventName, mfName, paramStr, options)
 			}
 
 			fmt.Fprintln(ctx.Output, ";")
diff --git a/mdl/executor/cmd_pages_builder_v3.go b/mdl/executor/cmd_pages_builder_v3.go
@@ -419,7 +419,7 @@ func applyWidgetAppearance(widget pages.Widget, w *ast.WidgetV3, theme *ThemeReg
 	if len(astProps) > 0 {
 		var dpValues []pages.DesignPropertyValue
 		for _, p := range astProps {
-			switch strings.ToUpper(p.Value) {
+			switch strings.ToLower(p.Value) {
 			case "on":
 				dpValues = append(dpValues, pages.DesignPropertyValue{
 					Key:       p.Key,
diff --git a/mdl/executor/cmd_rest_clients.go b/mdl/executor/cmd_rest_clients.go
@@ -146,7 +146,7 @@ func outputRestOperation(w io.Writer, op *model.RestClientOperation) {
 	}
 
 	fmt.Fprintf(w, "  operation %s {\n", op.Name)
-	fmt.Fprintf(w, "    Method: %s,\n", op.HttpMethod)
+	fmt.Fprintf(w, "    Method: %s,\n", strings.ToLower(op.HttpMethod))
 	fmt.Fprintf(w, "    Path: '%s',\n", op.Path)
 
 	// Parameters: ($var: Type, ...)
diff --git a/mdl/executor/cmd_settings.go b/mdl/executor/cmd_settings.go
@@ -178,7 +178,7 @@ func alterSettings(ctx *ExecContext, stmt *ast.AlterSettingsStmt) error {
 		return mdlerrors.NewBackend("read project settings", err)
 	}
 
-	section := strings.ToUpper(stmt.Section)
+	section := strings.ToLower(stmt.Section)
 	switch section {
 	case "model":
 		if ps.Model == nil {
diff --git a/mdl/visitor/visitor_page_v3.go b/mdl/visitor/visitor_page_v3.go
@@ -1088,10 +1088,10 @@ func buildDesignPropertyEntryV3(ctx parser.IDesignPropertyEntryV3Context) *ast.D
 
 	// Value: second STRING_LITERAL, ON, or OFF
 	if entryCtx.ON() != nil {
-		return &ast.DesignPropertyEntryV3{Key: key, Value: "ON"}
+		return &ast.DesignPropertyEntryV3{Key: key, Value: "on"}
 	}
 	if entryCtx.OFF() != nil {
-		return &ast.DesignPropertyEntryV3{Key: key, Value: "OFF"}
+		return &ast.DesignPropertyEntryV3{Key: key, Value: "off"}
 	}
 	if len(allStrings) >= 2 {
 		return &ast.DesignPropertyEntryV3{Key: key, Value: unquoteString(allStrings[1].GetText())}
diff --git a/mdl/visitor/visitor_rest.go b/mdl/visitor/visitor_rest.go
@@ -139,7 +139,7 @@ func parseRestClientOpProp(ctx *parser.RestClientOpPropContext, op *ast.RestOper
 
 	// Method: GET
 	if mCtx := ctx.RestHttpMethod(); mCtx != nil {
-		op.Method = strings.ToUpper(mCtx.GetText())
+		op.Method = strings.ToLower(mCtx.GetText())
 		return
 	}
 
diff --git a/mdl/visitor/visitor_settings.go b/mdl/visitor/visitor_settings.go
@@ -17,7 +17,7 @@ func (b *Builder) ExitAlterSettingsClause(ctx *parser.AlterSettingsClauseContext
 
 	if ctx.DROP() != nil && ctx.CONSTANT() != nil {
 		// ALTER SETTINGS DROP CONSTANT 'name' [IN CONFIGURATION 'cfg']
-		stmt.Section = "CONSTANT"
+		stmt.Section = "constant"
 		stmt.DropConstant = true
 		allStrings := ctx.AllSTRING_LITERAL()
 		if len(allStrings) > 0 {
@@ -28,7 +28,7 @@ func (b *Builder) ExitAlterSettingsClause(ctx *parser.AlterSettingsClauseContext
 		}
 	} else if ctx.CONSTANT() != nil {
 		// ALTER SETTINGS CONSTANT 'name' (VALUE 'value' | DROP) [IN CONFIGURATION 'cfg']
-		stmt.Section = "CONSTANT"
+		stmt.Section = "constant"
 		allStrings := ctx.AllSTRING_LITERAL()
 		if len(allStrings) > 0 {
 			stmt.ConstantId = unquoteString(allStrings[0].GetText())
@@ -44,7 +44,7 @@ func (b *Builder) ExitAlterSettingsClause(ctx *parser.AlterSettingsClauseContext
 		}
 	} else if ctx.CONFIGURATION() != nil {
 		// ALTER SETTINGS CONFIGURATION 'name' Key = Value, ...
-		stmt.Section = "CONFIGURATION"
+		stmt.Section = "configuration"
 		allStrings := ctx.AllSTRING_LITERAL()
 		if len(allStrings) > 0 {
 			stmt.ConfigName = unquoteString(allStrings[0].GetText())
diff --git a/mdl/visitor/visitor_workflow.go b/mdl/visitor/visitor_workflow.go
@@ -278,28 +278,28 @@ func buildWorkflowSetPropertyOp(ctx *parser.WorkflowSetPropertyContext) *ast.Set
 	op := &ast.SetWorkflowPropertyOp{}
 
 	if ctx.DISPLAY() != nil {
-		op.Property = "DISPLAY"
+		op.Property = "display"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	} else if ctx.DESCRIPTION() != nil {
-		op.Property = "DESCRIPTION"
+		op.Property = "description"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	} else if ctx.EXPORT() != nil {
-		op.Property = "EXPORT_LEVEL"
+		op.Property = "export_level"
 		if ctx.API() != nil {
 			op.Value = "API"
 		} else if ctx.IDENTIFIER() != nil {
 			op.Value = ctx.IDENTIFIER().GetText()
 		}
 	} else if ctx.DUE() != nil {
-		op.Property = "DUE_DATE"
+		op.Property = "due_date"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	} else if ctx.OVERVIEW() != nil {
-		op.Property = "OVERVIEW_PAGE"
+		op.Property = "overview_page"
 		if qn := ctx.QualifiedName(); qn != nil {
 			op.Entity = buildQualifiedName(qn)
 		}
 	} else if ctx.PARAMETER() != nil {
-		op.Property = "PARAMETER"
+		op.Property = "parameter"
 		op.Value = ctx.VARIABLE().GetText()
 		if qn := ctx.QualifiedName(); qn != nil {
 			op.Entity = buildQualifiedName(qn)
@@ -317,23 +317,23 @@ func buildActivitySetPropertyOp(ctx *parser.ActivitySetPropertyContext, ref stri
 	}
 
 	if ctx.PAGE() != nil {
-		op.Property = "PAGE"
+		op.Property = "page"
 		if qn := ctx.QualifiedName(); qn != nil {
 			op.PageName = buildQualifiedName(qn)
 		}
 	} else if ctx.DESCRIPTION() != nil {
-		op.Property = "DESCRIPTION"
+		op.Property = "description"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	} else if ctx.TARGETING() != nil && ctx.MICROFLOW() != nil {
-		op.Property = "TARGETING_MICROFLOW"
+		op.Property = "targeting_microflow"
 		if qn := ctx.QualifiedName(); qn != nil {
 			op.Microflow = buildQualifiedName(qn)
 		}
 	} else if ctx.TARGETING() != nil && ctx.XPATH() != nil {
-		op.Property = "TARGETING_XPATH"
+		op.Property = "targeting_xpath"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	} else if ctx.DUE() != nil {
-		op.Property = "DUE_DATE"
+		op.Property = "due_date"
 		op.Value = unquoteString(ctx.STRING_LITERAL().GetText())
 	}
 
diff --git a/mdl/visitor/visitor_workflow_test.go b/mdl/visitor/visitor_workflow_test.go
@@ -612,7 +612,7 @@ func TestAlterWorkflow_SetDisplay(t *testing.T) {
 	if !ok {
 		t.Fatalf("Expected SetWorkflowPropertyOp, got %T", stmt.Operations[0])
 	}
-	if op.Property != "DISPLAY" {
+	if op.Property != "display" {
 		t.Errorf("Expected Property 'DISPLAY', got %q", op.Property)
 	}
 	if op.Value != "New Display Name" {
@@ -645,10 +645,10 @@ func TestAlterWorkflow_MultipleOperations(t *testing.T) {
 		prop  string
 		value string
 	}{
-		{"DISPLAY", "Updated Approval"},
-		{"DESCRIPTION", "Updated description"},
-		{"EXPORT_LEVEL", "Hidden"},
-		{"DUE_DATE", "PT48H"},
+		{"display", "Updated Approval"},
+		{"description", "Updated description"},
+		{"export_level", "Hidden"},
+		{"due_date", "PT48H"},
 	}
 
 	for i, check := range checks {
@@ -685,7 +685,7 @@ func TestAlterWorkflow_SetActivityPage(t *testing.T) {
 	if !ok {
 		t.Fatalf("Expected SetActivityPropertyOp, got %T", stmt.Operations[0])
 	}
-	if op.Property != "PAGE" {
+	if op.Property != "page" {
 		t.Errorf("Expected Property 'PAGE', got %q", op.Property)
 	}
 	if op.ActivityRef != "Review" {
@@ -716,7 +716,7 @@ func TestAlterWorkflow_SetActivityWithAtPosition(t *testing.T) {
 	if op.AtPosition != 2 {
 		t.Errorf("Expected AtPosition 2, got %d", op.AtPosition)
 	}
-	if op.Property != "DESCRIPTION" {
+	if op.Property != "description" {
 		t.Errorf("Expected Property 'DESCRIPTION', got %q", op.Property)
 	}
 	if op.Value != "Updated desc" {
@@ -1002,7 +1002,7 @@ func TestAlterWorkflow_SetParameter(t *testing.T) {
 	if !ok {
 		t.Fatalf("Expected SetWorkflowPropertyOp, got %T", stmt.Operations[0])
 	}
-	if op.Property != "PARAMETER" {
+	if op.Property != "parameter" {
 		t.Errorf("Expected Property 'PARAMETER', got %q", op.Property)
 	}
 	if op.Value != "$ctx" {
@@ -1029,7 +1029,7 @@ func TestAlterWorkflow_SetOverviewPage(t *testing.T) {
 	if !ok {
 		t.Fatalf("Expected SetWorkflowPropertyOp, got %T", stmt.Operations[0])
 	}
-	if op.Property != "OVERVIEW_PAGE" {
+	if op.Property != "overview_page" {
 		t.Errorf("Expected Property 'OVERVIEW_PAGE', got %q", op.Property)
 	}
 	if op.Entity.Module != "M" || op.Entity.Name != "AdminPage" {
@@ -1056,15 +1056,15 @@ func TestAlterWorkflow_SetActivityTargeting(t *testing.T) {
 	}
 
 	mfOp := stmt.Operations[0].(*ast.SetActivityPropertyOp)
-	if mfOp.Property != "TARGETING_MICROFLOW" {
+	if mfOp.Property != "targeting_microflow" {
 		t.Errorf("Expected Property 'TARGETING_MICROFLOW', got %q", mfOp.Property)
 	}
 	if mfOp.Microflow.Name != "GetReviewers" {
 		t.Errorf("Expected Microflow 'GetReviewers', got %q", mfOp.Microflow.Name)
 	}
 
 	xpOp := stmt.Operations[1].(*ast.SetActivityPropertyOp)
-	if xpOp.Property != "TARGETING_XPATH" {
+	if xpOp.Property != "targeting_xpath" {
 		t.Errorf("Expected Property 'TARGETING_XPATH', got %q", xpOp.Property)
 	}
 	if xpOp.Value != "[Role = 'Manager']" {
@@ -1085,7 +1085,7 @@ func TestAlterWorkflow_SetActivityDueDate(t *testing.T) {
 
 	stmt := prog.Statements[0].(*ast.AlterWorkflowStmt)
 	op := stmt.Operations[0].(*ast.SetActivityPropertyOp)
-	if op.Property != "DUE_DATE" {
+	if op.Property != "due_date" {
 		t.Errorf("Expected Property 'DUE_DATE', got %q", op.Property)
 	}
 	if op.Value != "PT72H" {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ func outputRestOperation(w io.Writer, op *model.RestClientOperation) {`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`fmt.Fprintf(w, " operation %s {\n", op.Name)`
`149`		`- fmt.Fprintf(w, " Method: %s,\n", op.HttpMethod)`
	`149`	`+ fmt.Fprintf(w, " Method: %s,\n", strings.ToLower(op.HttpMethod))`
`150`	`150`	`fmt.Fprintf(w, " Path: '%s',\n", op.Path)`
`151`	`151`
`152`	`152`	`// Parameters: ($var: Type, ...)`
Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ func alterSettings(ctx ExecContext, stmt ast.AlterSettingsStmt) error {`
`178`	`178`	`return mdlerrors.NewBackend("read project settings", err)`
`179`	`179`	`}`
`180`	`180`
`181`		`- section := strings.ToUpper(stmt.Section)`
	`181`	`+ section := strings.ToLower(stmt.Section)`
`182`	`182`	`switch section {`
`183`	`183`	`case "model":`
`184`	`184`	`if ps.Model == nil {`
Original file line number	Diff line number	Diff line change
`@@ -1088,10 +1088,10 @@ func buildDesignPropertyEntryV3(ctx parser.IDesignPropertyEntryV3Context) *ast.D`
`1088`	`1088`
`1089`	`1089`	`// Value: second STRING_LITERAL, ON, or OFF`
`1090`	`1090`	`if entryCtx.ON() != nil {`
`1091`		`- return &ast.DesignPropertyEntryV3{Key: key, Value: "ON"}`
	`1091`	`+ return &ast.DesignPropertyEntryV3{Key: key, Value: "on"}`
`1092`	`1092`	`}`
`1093`	`1093`	`if entryCtx.OFF() != nil {`
`1094`		`- return &ast.DesignPropertyEntryV3{Key: key, Value: "OFF"}`
	`1094`	`+ return &ast.DesignPropertyEntryV3{Key: key, Value: "off"}`
`1095`	`1095`	`}`
`1096`	`1096`	`if len(allStrings) >= 2 {`
`1097`	`1097`	`return &ast.DesignPropertyEntryV3{Key: key, Value: unquoteString(allStrings[1].GetText())}`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ func parseRestClientOpProp(ctx parser.RestClientOpPropContext, op ast.RestOper`
`139`	`139`
`140`	`140`	`// Method: GET`
`141`	`141`	`if mCtx := ctx.RestHttpMethod(); mCtx != nil {`
`142`		`- op.Method = strings.ToUpper(mCtx.GetText())`
	`142`	`+ op.Method = strings.ToLower(mCtx.GetText())`
`143`	`143`	`return`
`144`	`144`	`}`
`145`	`145`