fix: iterate bytes in UUIDToBlob, use local aliases in tests

Author: retran

mdl/types/id.go

@@ -55,9 +55,9 @@ func UUIDToBlob(uuid string) []byte {
 	}
 	var clean strings.Builder
 	clean.Grow(32)
-	for _, c := range uuid {
-		if c != '-' {
-			clean.WriteByte(byte(c))
+	for i := 0; i < len(uuid); i++ {
+		if uuid[i] != '-' {
+			clean.WriteByte(uuid[i])
 		}
 	}
 	decoded, err := hex.DecodeString(clean.String())

sdk/mpr/writer_imagecollection_test.go

@@ -5,13 +5,12 @@ package mpr
 import (
 	"testing"
 
-	"github.com/mendixlabs/mxcli/mdl/types"
 	"github.com/mendixlabs/mxcli/model"
 	"go.mongodb.org/mongo-driver/bson"
 )
 
 func TestSerializeImageCollection_EmptyImages(t *testing.T) {
-	ic := &types.ImageCollection{
+	ic := &ImageCollection{
 		BaseElement: model.BaseElement{ID: "ic-test-1"},
 		ContainerID: model.ID("module-id-1"),
 		Name:        "TestIcons",
@@ -59,7 +58,7 @@ func TestSerializeImageCollection_EmptyImages(t *testing.T) {
 }
 
 func TestSerializeImageCollection_DefaultExportLevel(t *testing.T) {
-	ic := &types.ImageCollection{
+	ic := &ImageCollection{
 		BaseElement: model.BaseElement{ID: "ic-test-2"},
 		ContainerID: model.ID("module-id-1"),
 		Name:        "Icons",