Merge pull request #474 from hjotha/submit/describer-empty-else-merge-flow

fix: emit merge flow for empty ELSE bodies (CE0079)

Author: ako

mdl/executor/cmd_microflows_builder_control.go

@@ -272,6 +272,12 @@ func (fb *flowBuilder) addIfStatement(s *ast.IfStmt) model.ID {
 				}
 				applyUserAnchors(flow, originAnchor, destAnchor)
 				fb.flows = append(fb.flows, flow)
+			} else {
+				// Explicit empty ELSE body: the split still needs a configured
+				// false case when both branches converge at the merge.
+				flow := newDownwardFlowWithCase(splitID, mergeID, "false")
+				applyUserAnchors(flow, falseBranchAnchor, falseBranchAnchor)
+				fb.flows = append(fb.flows, flow)
 			}
 		} else if elseReturns && needMerge {
 			fb.addPendingErrorHandlerFlowTo(mergeID)

mdl/executor/cmd_microflows_builder_empty_else_merge_test.go

@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package executor
+
+import (
+	"testing"
+
+	"github.com/mendixlabs/mxcli/mdl/ast"
+	"github.com/mendixlabs/mxcli/sdk/microflows"
+)
+
+// TestIfEmptyElseBodyWithContinuingThenEmitsFalseFlowToMerge is a regression
+// guard for CE0079 ("The 'false' condition value should be configured in
+// properties for an outgoing flow").
+//
+// Pattern: an IF with THEN that continues and an explicitly empty ELSE body.
+// Both branches must feed a merge, but an empty ELSE has no lastElseID to wire.
+func TestIfEmptyElseBodyWithContinuingThenEmitsFalseFlowToMerge(t *testing.T) {
+	fb := &flowBuilder{
+		spacing:  HorizontalSpacing,
+		measurer: &layoutMeasurer{},
+	}
+
+	fb.addIfStatement(&ast.IfStmt{
+		Condition: &ast.VariableExpr{Name: "Flag"},
+		ThenBody: []ast.MicroflowStatement{
+			&ast.LogStmt{Level: ast.LogInfo, Message: &ast.LiteralExpr{Kind: ast.LiteralString, Value: "in-then"}},
+		},
+		// The source had an explicit ELSE token, but no statements in that
+		// branch. That must still build a false split->merge flow.
+		HasElse: true,
+	})
+
+	var split *microflows.ExclusiveSplit
+	var merge *microflows.ExclusiveMerge
+	for _, obj := range fb.objects {
+		switch o := obj.(type) {
+		case *microflows.ExclusiveSplit:
+			split = o
+		case *microflows.ExclusiveMerge:
+			merge = o
+		}
+	}
+	if split == nil {
+		t.Fatal("expected ExclusiveSplit to be created")
+	}
+	if merge == nil {
+		t.Fatal("expected ExclusiveMerge to be created")
+	}
+
+	var hasFalseFlow bool
+	for _, flow := range fb.flows {
+		if flow.OriginID != split.ID || flow.DestinationID != merge.ID {
+			continue
+		}
+		if ec, ok := flow.CaseValue.(microflows.EnumerationCase); ok && ec.Value == "false" {
+			hasFalseFlow = true
+		}
+	}
+	if !hasFalseFlow {
+		t.Fatal("missing split->merge flow with case \"false\"")
+	}
+}