Skip to content

Commit 4cb0501

Browse files
committed
fix: address PR #224 review feedback
- NotConnected → NotConnectedWrite in all write-requiring handlers - NewNotConnectedMsg constructor for custom hints (cmd_features.go) - Timeout returns ValidationError instead of plain fmt.Errorf - Standardize RawUnitBackend on model.ID - Registry panic prefix corrected to 'registry:' - Full qualified names in AlreadyExists/NotFound messages - Import/export mapping: distinguish not-found from backend errors - Published REST: propagate backend errors, include qualified names - Clarify unhandled statement error message in registry dispatch - Registry.Validate returns ValidationError instead of plain fmt.Errorf - Split MockBackend into 13 domain-specific files - Introduce EntityAccessRuleParams struct for AddEntityAccessRule - Move mpr type extraction TODO to project tracker
1 parent 5d24fe2 commit 4cb0501

34 files changed

+1594
-1486
lines changed

mdl/backend/doc.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// executor from concrete storage (e.g. .mpr files). Each interface
55
// groups related read/write operations by domain concept.
66
//
7-
// TODO: Several method signatures currently reference types from sdk/mpr
7+
// Several method signatures currently reference types from sdk/mpr
88
// (e.g. NavigationDocument, FolderInfo, ImageCollection, JsonStructure,
99
// JavaAction, EntityMemberAccess, RenameHit). These should eventually be
1010
// extracted into a shared types package to remove the mpr dependency.

mdl/backend/infrastructure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ type RenameBackend interface {
1919
// manipulate raw BSON (e.g. widget patching, alter page/workflow).
2020
type RawUnitBackend interface {
2121
GetRawUnit(id model.ID) (map[string]any, error)
22-
GetRawUnitBytes(id string) ([]byte, error)
22+
GetRawUnitBytes(id model.ID) ([]byte, error)
2323
ListRawUnitsByType(typePrefix string) ([]*mpr.RawUnit, error)
2424
ListRawUnits(objectType string) ([]*mpr.RawUnitInfo, error)
2525
GetRawUnitByName(objectType, qualifiedName string) (*mpr.RawUnitInfo, error)

0 commit comments

Comments
 (0)