Skip to content

Commit 57f8739

Browse files
committed
fixup: drop unused RuleID field on RuleSplitCondition
Per PR review — the field was only set by the parser but never read anywhere. The rule call is already identified by RuleQualifiedName, which is what both the writer and describer use.
1 parent 56d8606 commit 57f8739

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

sdk/microflows/microflows.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@ func (ExpressionSplitCondition) isSplitCondition() {}
294294
// "RuleCall.Microflow" field (rules and microflows share a namespace).
295295
type RuleSplitCondition struct {
296296
model.BaseElement
297-
RuleID model.ID `json:"ruleId"`
298297
RuleQualifiedName string `json:"ruleQualifiedName,omitempty"`
299298
ParameterMappings []*RuleCallParameterMapping `json:"parameterMappings,omitempty"`
300299
}

sdk/mpr/parser_microflow.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,9 +456,7 @@ func parseSplitCondition(raw map[string]any) microflows.SplitCondition {
456456
Expression: extractString(raw["Expression"]),
457457
}
458458
case "Microflows$RuleSplitCondition":
459-
cond := &microflows.RuleSplitCondition{
460-
RuleID: model.ID(extractBsonID(raw["Rule"])),
461-
}
459+
cond := &microflows.RuleSplitCondition{}
462460
// Mendix nests the rule reference under a RuleCall sub-document whose
463461
// "Microflow" field holds the rule's qualified name (rules share the
464462
// microflow namespace). Parameter mappings are scoped inside RuleCall too.

0 commit comments

Comments
 (0)