Commit 5a2bc46
fix: address PR #68 review + migrate filter widgets to engine
Review fixes:
- Remove 7 debug log.Printf calls + timelineCustom debug block
- deepCloneMap returns error instead of silent nil
- Mode fallback returns error for ambiguous multiple defaults
- createAttributeObject validates path format upfront
- Association mapping validates EntityName is set
Engine migration:
- Add attributeObjects operation for Attributes: [...] → BSON Objects
- Create .def.json for TEXTFILTER/NUMBERFILTER/DROPDOWNFILTER/DATEFILTER
- Delete ~200 lines of hardcoded filter builders
- Add DROPDOWNSORT full-stack (lexer/parser/describe/def.json)
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 38b7e51 commit 5a2bc46
19 files changed
Lines changed: 4547 additions & 4812 deletions
File tree
- mdl
- executor
- grammar
- parser
- sdk/widgets
- definitions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
311 | 311 | | |
312 | 312 | | |
313 | 313 | | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | 314 | | |
323 | 315 | | |
324 | 316 | | |
| |||
0 commit comments