fix: move update-widgets to widget-specific tests only

Running mx update-widgets globally in runMxCheck caused
StorageFormatException on non-widget tests (e.g., Java actions).
Move update-widgets to targeted call sites: doctype tests (before
mx check), ComboBox test, and Gallery test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: 2 people

mdl/executor/roundtrip_doctype_test.go

@@ -156,6 +156,12 @@ func TestMxCheck_DoctypeScripts(t *testing.T) {
 			// Flush to disk
 			env.executor.Execute(&ast.DisconnectStmt{})
 
+			// Update widgets for scripts that create pluggable widgets (prevents CE0463).
+			// Skip for other scripts — update-widgets can corrupt non-widget projects.
+			if strings.Contains(name, "page") || strings.Contains(name, "widget") {
+				runMxUpdateWidgets(t, env.projectPath)
+			}
+
 			// Run mx check
 			output, mxErr := runMxCheck(t, env.projectPath)
 			if mxErr != nil {

mdl/executor/roundtrip_mxcheck_datagrid_test.go

@@ -183,6 +183,8 @@ func TestMxCheck_GalleryPage(t *testing.T) {
 
 	env.executor.Execute(&ast.DisconnectStmt{})
 
+	runMxUpdateWidgets(t, env.projectPath)
+
 	output, err := runMxCheck(t, env.projectPath)
 	if err != nil {
 		if strings.Contains(output, "placeholder") || strings.Contains(output, "CE0463") {

mdl/executor/roundtrip_mxcheck_test.go

@@ -31,17 +31,22 @@ func runMxCheck(t *testing.T, projectPath string) (string, error) {
 		return "", fmt.Errorf("mx binary not found")
 	}
 
-	// Update widgets before checking — ensures widget definitions match templates.
-	// Without this, programmatically created widgets may trigger CE0463 if the
-	// embedded template has fewer/more properties than the mpk version expects.
-	updateCmd := exec.Command(mxPath, "update-widgets", projectPath)
-	updateCmd.CombinedOutput() // best-effort, ignore errors
-
 	cmd := exec.Command(mxPath, "check", projectPath)
 	output, err := cmd.CombinedOutput()
 	return string(output), err
 }
 
+// runMxUpdateWidgets synchronizes widget definitions with mpk files.
+// Call before runMxCheck on tests that create pluggable widgets.
+func runMxUpdateWidgets(t *testing.T, projectPath string) {
+	t.Helper()
+	mxPath := findMxBinary()
+	if mxPath == "" {
+		return
+	}
+	exec.Command(mxPath, "update-widgets", projectPath).CombinedOutput()
+}
+
 // TestMxCheck_Entity creates an entity and verifies mx check passes.
 func TestMxCheck_Entity(t *testing.T) {
 	if !mxCheckAvailable() {
@@ -836,6 +841,8 @@ END;`
 	// Disconnect to flush changes
 	env.executor.Execute(&ast.DisconnectStmt{})
 
+	runMxUpdateWidgets(t, env.projectPath)
+
 	// Run mx check
 	output, err := runMxCheck(t, env.projectPath)
 	if err != nil {