Skip to content

Commit 6ba80eb

Browse files
hjothamendixclaude
andcommitted
docs: clarify ParameterMappings storage-list marker comment
The legacy SOAP writer had a misleading comment claiming the leading `int32(2)` of an empty ParameterMappings array was a "declared count". It is actually the Mendix storage-list-type marker — the same constant used by every other empty list writer in this file (see PR #338 for showpage and PR #374 for change-action items). Addresses ako's review on PR #334. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent fb58756 commit 6ba80eb

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

sdk/mpr/writer_microflow_actions.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -615,10 +615,12 @@ func serializeWebServiceCallAction(a *microflows.WebServiceCallAction) bson.D {
615615
{Key: "$ID", Value: idToBsonBinary(GenerateID())},
616616
{Key: "$Type", Value: "Microflows$ExportMappingCall"},
617617
{Key: "Mapping", Value: string(a.SendMappingID)},
618-
// Studio Pro uses an array whose first element is the declared
619-
// count. The legacy SOAP fixture has no parameter mappings, so
620-
// this marker matches the empty ExportMappingCall shape used by
621-
// existing microflow/rule-call writers.
618+
// Mendix storage lists encode their first element as a
619+
// constant storage-list-type marker (`2` for object lists),
620+
// NOT the element count. The empty ExportMappingCall shape
621+
// used by other writers in this file follows the same
622+
// convention; see #338 / #374 for prior fixes that aligned
623+
// other writers on this marker.
622624
{Key: "ParameterMappings", Value: bson.A{int32(2)}},
623625
}},
624626
}})

0 commit comments

Comments
 (0)