Skip to content

Commit 9095513

Browse files
hjothamendixclaude
andcommitted
docs: clarify ParameterMappings storage-list marker comment
The legacy SOAP writer had a misleading comment claiming the leading `int32(2)` of an empty ParameterMappings array was a "declared count". It is actually the Mendix storage-list-type marker — the same constant used by every other empty list writer in this file (see PR #338 for showpage and PR #374 for change-action items). Addresses ako's review on PR #334. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 parent cffcd77 commit 9095513

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

mdl/executor/cmd_microflows_builder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ type flowBuilder struct {
5353
microflowsCacheLoaded bool
5454
nanoflowsCache []*microflows.Nanoflow
5555
nanoflowsCacheLoaded bool
56-
manualLoopBackTarget model.ID
56+
manualLoopBackTarget model.ID
5757
}
5858

5959
// addError records a validation error during flow building.

sdk/mpr/writer_microflow_actions.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -702,10 +702,12 @@ func serializeWebServiceCallAction(a *microflows.WebServiceCallAction) bson.D {
702702
{Key: "$ID", Value: idToBsonBinary(GenerateID())},
703703
{Key: "$Type", Value: "Microflows$ExportMappingCall"},
704704
{Key: "Mapping", Value: string(a.SendMappingID)},
705-
// Studio Pro uses an array whose first element is the declared
706-
// count. The legacy SOAP fixture has no parameter mappings, so
707-
// this marker matches the empty ExportMappingCall shape used by
708-
// existing microflow/rule-call writers.
705+
// Mendix storage lists encode their first element as a
706+
// constant storage-list-type marker (`2` for object lists),
707+
// NOT the element count. The empty ExportMappingCall shape
708+
// used by other writers in this file follows the same
709+
// convention; see #338 / #374 for prior fixes that aligned
710+
// other writers on this marker.
709711
{Key: "ParameterMappings", Value: bson.A{int32(2)}},
710712
}},
711713
}})

0 commit comments

Comments
 (0)