fix: repair lowercase convention regressions in widget builder and MDL examples

ako · claude · ako · commit 9b76c0770ac2 · 2026-04-21T15:43:12.000Z
The initial lowercase conversion had several bugs:

- Widget builder used strings.ToUpper(w.Type) with lowercase case values,
  causing "unsupported widget type: layoutgrid/datagrid" at runtime. Fixed
  all ToUpper → ToLower in page builder, widget engine, and validation code.

- MDL example files had qualified identifiers after '.' incorrectly lowercased
  (System.Image → System.image, System.User → System.User, etc.) because the
  conversion script did not protect all identifier positions. Restored correct
  Mendix entity/role name casing.

- Business event attribute types (Long, String) stored as raw parser text were
  now lowercase. Added canonical casing map in dataTypeSimpleName() so the
  BSON always receives "Long", "String", etc. regardless of MDL input casing.

- publish/subscribe switch and objectType switches used ToUpper against
  lowercase case values. Fixed to ToLower throughout.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/mdl-examples/doctype-tests/01-domain-model-examples.mdl b/mdl-examples/doctype-tests/01-domain-model-examples.mdl
@@ -1692,7 +1692,7 @@ create persistent entity DmTest.Attachment extends System.FileDocument (
  * plus adds metadata for product catalog display.
  */
 @position(2300, 200)
-create persistent entity DmTest.ProductPhoto extends System.image (
+create persistent entity DmTest.ProductPhoto extends System.Image (
   /** Photo caption for display */
   PhotoCaption: string(200),
   /** Display sort order */
@@ -1784,7 +1784,7 @@ create persistent entity DmTest.InternalDocument extends System.FileDocument;
  * Both keywords are supported; EXTENDS is preferred for new code.
  */
 @position(2300, 600)
-create persistent entity DmTest.ProfilePhoto generalization System.image (
+create persistent entity DmTest.ProfilePhoto generalization System.Image (
   /** Whether this photo has been approved by admin */
   IsApproved: boolean default false
 );
diff --git a/mdl-examples/doctype-tests/06-rest-client-examples.mdl b/mdl-examples/doctype-tests/06-rest-client-examples.mdl
@@ -793,7 +793,7 @@ begin
   -- $latestHttpResponse is a system variable (System.HttpResponse) that is
   -- automatically populated after SEND REST REQUEST. Check its Content
   -- attribute to determine if the call returned data.
-  if $latestHttpResponse/content != empty then
+  if $latestHttpResponse/Content != empty then
     set $success = true;
     log info node 'RestTest' 'ACT_TestHeaders: headers echoed';
   else
diff --git a/mdl-examples/doctype-tests/08-security-examples.mdl b/mdl-examples/doctype-tests/08-security-examples.mdl
@@ -191,11 +191,11 @@ describe user role 'Administrator';
 /**
  * Create a simple module role without description.
  */
-create module role SecTest.user;
+create module role SecTest.User;
 /
 
 -- Describe a specific module role (shows DDL + which user roles include it)
-describe module role SecTest.user;
+describe module role SecTest.User;
 
 -- ============================================================================
 -- Level 2.2: Module Role with Description
@@ -235,7 +235,7 @@ create module role SecTest.Viewer description 'Read-only access for viewing data
 /**
  * Allow the User role to execute the customer creation microflow.
  */
-grant execute on microflow SecTest.ACT_Customer_Create to SecTest.user;
+grant execute on microflow SecTest.ACT_Customer_Create to SecTest.User;
 /
 
 -- Verify the grant
@@ -249,7 +249,7 @@ show access on microflow SecTest.ACT_Customer_Create;
 /**
  * Allow both User and Administrator roles to process orders.
  */
-grant execute on microflow SecTest.ACT_Order_Process to SecTest.user, SecTest.Administrator;
+grant execute on microflow SecTest.ACT_Order_Process to SecTest.User, SecTest.Administrator;
 /
 
 -- ============================================================================
@@ -269,7 +269,7 @@ grant execute on microflow SecTest.ACT_Customer_Delete to SecTest.Administrator;
 /**
  * Remove User's ability to process orders (admin-only now).
  */
-revoke execute on microflow SecTest.ACT_Order_Process from SecTest.user;
+revoke execute on microflow SecTest.ACT_Order_Process from SecTest.User;
 /
 
 -- Verify the revoke
@@ -290,7 +290,7 @@ revoke execute on microflow SecTest.ACT_Customer_Delete from SecTest.Administrat
 /**
  * Granting a role that already has access is a no-op (safe to repeat).
  */
-grant execute on microflow SecTest.ACT_Customer_Create to SecTest.user;
+grant execute on microflow SecTest.ACT_Customer_Create to SecTest.User;
 /
 
 
@@ -308,7 +308,7 @@ grant execute on microflow SecTest.ACT_Customer_Create to SecTest.user;
 /**
  * Allow users to view the customer overview page.
  */
-grant view on page SecTest.Customer_Overview to SecTest.user;
+grant view on page SecTest.Customer_Overview to SecTest.User;
 /
 
 -- Verify
@@ -322,7 +322,7 @@ show access on page SecTest.Customer_Overview;
 /**
  * Allow both users and administrators to view orders.
  */
-grant view on page SecTest.Order_Overview to SecTest.user, SecTest.Administrator;
+grant view on page SecTest.Order_Overview to SecTest.User, SecTest.Administrator;
 /
 
 -- ============================================================================
@@ -332,7 +332,7 @@ grant view on page SecTest.Order_Overview to SecTest.user, SecTest.Administrator
 /**
  * Remove User's view access on order overview (admin-only now).
  */
-revoke view on page SecTest.Order_Overview from SecTest.user;
+revoke view on page SecTest.Order_Overview from SecTest.User;
 /
 
 -- Verify - should only show Administrator
@@ -374,7 +374,7 @@ grant SecTest.Viewer on SecTest.Customer (read *);
 /**
  * Grant read access to specific attributes, write to a subset.
  */
-grant SecTest.user on SecTest.Customer (read (Name, Email), write (Email));
+grant SecTest.User on SecTest.Customer (read (Name, Email), write (Email));
 /
 
 -- ============================================================================
@@ -384,7 +384,7 @@ grant SecTest.user on SecTest.Customer (read (Name, Email), write (Email));
 /**
  * Grant access only to active customers using an XPath constraint.
  */
-grant SecTest.user on SecTest.Order (read *, write *) where '[Status = ''Open'']';
+grant SecTest.User on SecTest.Order (read *, write *) where '[Status = ''Open'']';
 /
 
 -- Verify entity access
@@ -398,7 +398,7 @@ show access on SecTest.Customer;
 /**
  * GRANT is additive: adding Notes access preserves existing Name and Email.
  */
-grant SecTest.user on SecTest.Customer (read (Notes));
+grant SecTest.User on SecTest.Customer (read (Notes));
 /
 
 -- ============================================================================
@@ -409,13 +409,13 @@ grant SecTest.user on SecTest.Customer (read (Notes));
  * Remove read access on a specific attribute (Notes).
  * Other permissions are preserved.
  */
-revoke SecTest.user on SecTest.Customer (read (Notes));
+revoke SecTest.User on SecTest.Customer (read (Notes));
 /
 
 /**
  * Downgrade write to read-only on Email.
  */
-revoke SecTest.user on SecTest.Customer (write (Email));
+revoke SecTest.User on SecTest.Customer (write (Email));
 /
 
 -- ============================================================================
@@ -446,7 +446,7 @@ show access on SecTest.Customer;
 /**
  * Create a user role and assign a single module role.
  */
-create or modify user role RegularUser (System.user, SecTest.user);
+create or modify user role RegularUser (System.User, SecTest.User);
 /
 
 -- ============================================================================
@@ -456,7 +456,7 @@ create or modify user role RegularUser (System.user, SecTest.user);
 /**
  * A user role can include roles from multiple modules.
  */
-create or modify user role PowerUser (System.user, SecTest.user, SecTest.Administrator);
+create or modify user role PowerUser (System.User, SecTest.User, SecTest.Administrator);
 /
 
 -- ============================================================================
@@ -607,7 +607,7 @@ create module role SecTest.Manager description 'Can manage customers and orders'
  * Step 2: Grant microflow access based on roles.
  * Users can create customers, managers and admins can do everything.
  */
-grant execute on microflow SecTest.ACT_Customer_Create to SecTest.user, SecTest.Manager;
+grant execute on microflow SecTest.ACT_Customer_Create to SecTest.User, SecTest.Manager;
 grant execute on microflow SecTest.ACT_Customer_Delete to SecTest.Manager, SecTest.Administrator;
 grant execute on microflow SecTest.ACT_Order_Process to SecTest.Manager, SecTest.Administrator;
 /
@@ -616,7 +616,7 @@ grant execute on microflow SecTest.ACT_Order_Process to SecTest.Manager, SecTest
  * Step 3: Grant page access based on roles.
  * All roles can see customers, only managers+ can see orders.
  */
-grant view on page SecTest.Customer_Overview to SecTest.user, SecTest.Manager, SecTest.Administrator;
+grant view on page SecTest.Customer_Overview to SecTest.User, SecTest.Manager, SecTest.Administrator;
 grant view on page SecTest.Order_Overview to SecTest.Manager, SecTest.Administrator;
 /
 
@@ -648,8 +648,8 @@ show access on page SecTest.Order_Overview;
 -- When a module has partial access rules (not all entities covered by all
 -- roles), MxBuild reports CE0066 regardless of security level.
 revoke SecTest.Administrator on SecTest.Customer;
-revoke SecTest.user on SecTest.Customer;
-revoke SecTest.user on SecTest.Order;
+revoke SecTest.User on SecTest.Customer;
+revoke SecTest.User on SecTest.Order;
 revoke SecTest.Manager on SecTest.Customer;
 
 
diff --git a/mdl-examples/doctype-tests/alter-workflow.mdl b/mdl-examples/doctype-tests/alter-workflow.mdl
@@ -65,13 +65,13 @@ end;
 
 -- Targeting microflow: (System.Workflow, context) -> List of System.User
 create microflow WFTest.ACT_TargetUsers (
-  $workflow: System.workflow,
+  $workflow: System.Workflow,
   $context: WFTest.OrderContext
 )
-returns list of System.user as $users
+returns list of System.User as $users
 begin
   @position(200,200)
-  retrieve $users from System.user;
+  retrieve $users from System.User;
   @position(400,200) return $users;
 end;
 /
@@ -109,7 +109,7 @@ create page WFTest.AlternateTaskPage (
 create page WFTest.OverviewPage (
   title: 'Workflow Overview',
   layout: Atlas_Core.Atlas_Default,
-  params: { $workflow: System.workflow }
+  params: { $workflow: System.Workflow }
 ) {
   layoutgrid g1 {
     row r1 {
diff --git a/mdl-examples/doctype-tests/workflow-microflow-actions.mdl b/mdl-examples/doctype-tests/workflow-microflow-actions.mdl
@@ -29,7 +29,7 @@ end workflow;
 -- ############################################################################
 
 create microflow TestModule.MF_WorkflowActions (
-  $workflow: System.workflow,
+  $workflow: System.Workflow,
   $ContextObj: TestModule.DeliveryContext,
   $UserTask: System.WorkflowUserTask
 )
diff --git a/mdl-examples/mes/02-catalog-domain-model.mdl b/mdl-examples/mes/02-catalog-domain-model.mdl
@@ -151,7 +151,7 @@ index (SKU);
  */
 @position(350, 250)
 create persistent entity ProductCatalog.ProductImage
-extends System.image (
+extends System.Image (
   /** Caption describing the image */
   ImageCaption: string(500),
   /** Whether this is the primary display image */
diff --git a/mdl/executor/cmd_businessevents.go b/mdl/executor/cmd_businessevents.go
@@ -331,7 +331,7 @@ func createBusinessEventService(ctx *ExecContext, stmt *ast.CreateBusinessEventS
 		msg.TypeName = "BusinessEvents$Message"
 
 		// Set publish/subscribe based on operation
-		switch strings.ToUpper(msgDef.Operation) {
+		switch strings.ToLower(msgDef.Operation) {
 		case "publish":
 			msg.CanSubscribe = true // Service publishes → others subscribe
 		case "subscribe":
diff --git a/mdl/executor/cmd_catalog.go b/mdl/executor/cmd_catalog.go
@@ -655,7 +655,7 @@ func captureDescribe(ctx *ExecContext, objectType string, qualifiedName string)
 	defer func() { ctx.Output = origOutput }()
 
 	var err error
-	switch strings.ToUpper(objectType) {
+	switch strings.ToLower(objectType) {
 	case "entity":
 		err = describeEntity(ctx, qn)
 	case "microflow", "nanoflow":
@@ -713,7 +713,7 @@ func captureDescribeParallel(ctx *ExecContext, objectType string, qualifiedName
 	}
 
 	var err error
-	switch strings.ToUpper(objectType) {
+	switch strings.ToLower(objectType) {
 	case "entity":
 		err = describeEntity(localCtx, qn)
 	case "microflow", "nanoflow":
diff --git a/mdl/executor/cmd_mermaid.go b/mdl/executor/cmd_mermaid.go
@@ -30,8 +30,8 @@ func describeMermaid(ctx *ExecContext, objectType, name string) error {
 		qn = ast.QualifiedName{Module: name}
 	}
 
-	switch strings.ToUpper(objectType) {
-	case "entity", "DOMAINMODEL":
+	switch strings.ToLower(objectType) {
+	case "entity", "domainmodel":
 		return domainModelToMermaid(ctx, qn.Module)
 	case "microflow":
 		return microflowToMermaid(ctx, qn)
diff --git a/mdl/executor/cmd_pages_builder_v3.go b/mdl/executor/cmd_pages_builder_v3.go
@@ -257,7 +257,7 @@ func (pb *pageBuilder) buildWidgetV3(w *ast.WidgetV3) (pages.Widget, error) {
 	var widget pages.Widget
 	var err error
 
-	switch strings.ToUpper(w.Type) {
+	switch strings.ToLower(w.Type) {
 	case "dataview":
 		widget, err = pb.buildDataViewV3(w)
 	case "datagrid":
diff --git a/mdl/executor/cmd_pages_builder_v3_layout.go b/mdl/executor/cmd_pages_builder_v3_layout.go
@@ -24,7 +24,7 @@ func (pb *pageBuilder) buildLayoutGridV3(w *ast.WidgetV3) (*pages.LayoutGrid, er
 
 	// Build rows from children
 	for _, child := range w.Children {
-		if strings.ToUpper(child.Type) == "row" {
+		if strings.ToLower(child.Type) == "row" {
 			row, err := pb.buildLayoutGridRowV3(child)
 			if err != nil {
 				return nil, err
@@ -46,7 +46,7 @@ func (pb *pageBuilder) buildLayoutGridRowV3(w *ast.WidgetV3) (*pages.LayoutGridR
 
 	// Build columns from children
 	for _, child := range w.Children {
-		if strings.ToUpper(child.Type) == "column" {
+		if strings.ToLower(child.Type) == "column" {
 			col, err := pb.buildLayoutGridColumnV3(child)
 			if err != nil {
 				return nil, err
@@ -228,7 +228,7 @@ func (pb *pageBuilder) buildTabContainerV3(w *ast.WidgetV3) (*pages.TabContainer
 
 	// Build tab pages from children
 	for _, child := range w.Children {
-		if strings.ToUpper(child.Type) == "tabpage" {
+		if strings.ToLower(child.Type) == "tabpage" {
 			tp, err := pb.buildTabPageV3(child)
 			if err != nil {
 				return nil, err
diff --git a/mdl/executor/cmd_pages_builder_v3_widgets.go b/mdl/executor/cmd_pages_builder_v3_widgets.go
@@ -108,7 +108,7 @@ func (pb *pageBuilder) buildDataGridV3(w *ast.WidgetV3) (*pages.CustomWidget, er
 	var columns []backend.DataGridColumnSpec
 	var headerWidgets []pages.Widget
 	for _, child := range w.Children {
-		switch strings.ToUpper(child.Type) {
+		switch strings.ToLower(child.Type) {
 		case "column":
 			attr := child.GetAttribute()
 			if attr == "" && child.Name != "" && len(child.Children) == 0 {
@@ -687,7 +687,7 @@ func (pb *pageBuilder) buildNavigationListV3(w *ast.WidgetV3) (*pages.Navigation
 
 	// Build items from children (ITEM widgets)
 	for _, child := range w.Children {
-		if strings.ToUpper(child.Type) == "item" {
+		if strings.ToLower(child.Type) == "item" {
 			item, err := pb.buildNavigationListItemV3(child)
 			if err != nil {
 				return nil, err
diff --git a/mdl/executor/validate_page_context.go b/mdl/executor/validate_page_context.go
@@ -75,9 +75,9 @@ func walkWidgetsWithContext(widgets []*ast.WidgetV3, paramNames map[string]bool,
 		}
 
 		// Check if this widget type is a data container that sets context
-		widgetType := strings.ToUpper(w.Type)
+		widgetType := strings.ToLower(w.Type)
 		switch widgetType {
-		case "dataview", "datagrid", "listview", "gallery", "TEMPLATEVIEW":
+		case "dataview", "datagrid", "listview", "gallery", "templateview":
 			if ds == nil {
 				// Data container without DataSource — context comes from enclosing container
 				childHasContext = hasEntityContext
diff --git a/mdl/executor/widget_engine.go b/mdl/executor/widget_engine.go
@@ -496,8 +496,8 @@ func (e *PluggableWidgetEngine) applyChildSlots(builder backend.WidgetObjectBuil
 	var defaultWidgets []pages.Widget
 
 	for _, child := range w.Children {
-		upperType := strings.ToUpper(child.Type)
-		if slot, ok := slotContainers[upperType]; ok {
+		lowerType := strings.ToLower(child.Type)
+		if slot, ok := slotContainers[lowerType]; ok {
 			for _, slotChild := range child.Children {
 				widget, err := e.pageBuilder.buildWidgetV3(slotChild)
 				if err != nil {
diff --git a/mdl/visitor/visitor_businessevents.go b/mdl/visitor/visitor_businessevents.go
@@ -103,5 +103,14 @@ func dataTypeSimpleName(ctx parser.IDataTypeContext) string {
 	if idx := strings.Index(text, "("); idx >= 0 {
 		text = text[:idx]
 	}
+	// Normalize to Mendix canonical casing (grammar is case-insensitive, Mendix BSON is not).
+	canonical := map[string]string{
+		"string": "String", "integer": "Integer", "long": "Long",
+		"decimal": "Decimal", "boolean": "Boolean", "datetime": "DateTime",
+		"binary": "Binary",
+	}
+	if c, ok := canonical[strings.ToLower(text)]; ok {
+		return c
+	}
 	return text
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ end workflow;`
`29`	`29`	`-- ############################################################################`
`30`	`30`
`31`	`31`	`create microflow TestModule.MF_WorkflowActions (`
`32`		`- $workflow: System.workflow,`
	`32`	`+ $workflow: System.Workflow,`
`33`	`33`	`$ContextObj: TestModule.DeliveryContext,`
`34`	`34`	`$UserTask: System.WorkflowUserTask`
`35`	`35`	`)`