fix: make macOS Applications dir mockable to fix test isolation

resolveStudioProDirMacOS and mendixSearchPaths hardcoded /Applications/,
so tests that set up fake cached binaries failed on dev machines with a
real Studio Pro installation — the resolver found the real app before
reaching the cache.

Introduce package-level macOSApplicationsDir (default /Applications) and
use it in both scan sites. Tests that verify cache-preference behaviour
now call setTestApplicationsDir(t, t.TempDir()) to redirect the scan
to an empty directory, eliminating the host-machine dependency.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: ako

cmd/mxcli/docker/check_test.go

@@ -122,6 +122,7 @@ func TestCheck_SkipUpdateWidgetsFlag(t *testing.T) {
 func TestResolveMxForVersion_PrefersExactCachedVersion(t *testing.T) {
 	dir := t.TempDir()
 	setTestHomeDir(t, dir)
+	setTestApplicationsDir(t, t.TempDir()) // prevent real macOS Studio Pro from matching
 	// Point PATH at an empty temp dir (rather than clearing it) so exec.LookPath
 	// still works for any other testing infrastructure but can't find mx.
 	t.Setenv("PATH", t.TempDir())

cmd/mxcli/docker/detect.go

@@ -36,6 +36,11 @@ import (
 	"strings"
 )
 
+// macOSApplicationsDir is the root directory scanned for Studio Pro .app bundles
+// on macOS. It is a package-level variable so tests can redirect it to a temp dir
+// to avoid interference from real Studio Pro installations on the test host.
+var macOSApplicationsDir = "/Applications"
+
 // mxbuildBinaryName returns the platform-specific mxbuild binary name.
 func mxbuildBinaryName() string {
 	if runtime.GOOS == "windows" {
@@ -164,7 +169,7 @@ func ResolveStudioProDir(version string) string {
 // where X.Y.Z is the base version (e.g., "11.10.0-rc.7 Beta" for 11.10.0).
 // Returns the bundle's Contents directory, or "" if not found.
 func resolveStudioProDirMacOS(version string) string {
-	matches, _ := filepath.Glob("/Applications/Mendix Studio Pro *.app")
+	matches, _ := filepath.Glob(filepath.Join(macOSApplicationsDir, "Mendix Studio Pro *.app"))
 	re := regexp.MustCompile(`^Mendix Studio Pro (\d+\.\d+\.\d+)`)
 	for _, match := range matches {
 		base := strings.TrimSuffix(filepath.Base(match), ".app")
@@ -217,7 +222,7 @@ func mendixSearchPaths(binaryName string) []string {
 		}
 		return paths
 	case "darwin":
-		return []string{"/Applications/Mendix Studio Pro *.app/Contents/modeler/" + binaryName}
+		return []string{filepath.Join(macOSApplicationsDir, "Mendix Studio Pro *.app", "Contents", "modeler", binaryName)}
 	default: // linux
 		paths := []string{filepath.Join("/opt/mendix/*/modeler", binaryName)}
 		if home, err := os.UserHomeDir(); err == nil {

cmd/mxcli/docker/detect_test.go

@@ -284,6 +284,7 @@ func TestResolveMxBuild_PrefersStudioProOverCache(t *testing.T) {
 func TestResolveMxBuild_PrefersExactCachedVersion(t *testing.T) {
 	dir := t.TempDir()
 	setTestHomeDir(t, dir)
+	setTestApplicationsDir(t, t.TempDir()) // prevent real macOS Studio Pro from matching
 	// Point PATH at an empty temp dir (rather than clearing it) so exec.LookPath
 	// still works for any other testing infrastructure but can't find mxbuild.
 	t.Setenv("PATH", t.TempDir())

cmd/mxcli/docker/download_test.go

@@ -18,6 +18,15 @@ func setTestHomeDir(t *testing.T, dir string) {
 	}
 }
 
+// setTestApplicationsDir redirects the macOS Applications directory scan to dir
+// so tests that set up cached binaries are not confused by real Studio Pro installs.
+func setTestApplicationsDir(t *testing.T, dir string) {
+	t.Helper()
+	prev := macOSApplicationsDir
+	macOSApplicationsDir = dir
+	t.Cleanup(func() { macOSApplicationsDir = prev })
+}
+
 func TestMxBuildCDNURL_ARM64(t *testing.T) {
 	url := MxBuildCDNURL("11.6.3", "arm64")
 	expected := "https://cdn.mendix.com/runtime/arm64-mxbuild-11.6.3.tar.gz"