fix: dedup batch bug, sort widgetsPropKeys, mock panic, remove no-op clone call

Author: retran

mdl/backend/mock/mock_microflow.go

@@ -53,7 +53,7 @@ func (m *MockBackend) ParseMicroflowFromRaw(raw map[string]any, unitID, containe
 	if m.ParseMicroflowFromRawFunc != nil {
 		return m.ParseMicroflowFromRawFunc(raw, unitID, containerID)
 	}
-	return nil
+	panic("mock ParseMicroflowFromRaw called but ParseMicroflowFromRawFunc is not set")
 }
 
 func (m *MockBackend) ListNanoflows() ([]*microflows.Nanoflow, error) {

mdl/backend/mpr/widget_builder.go

@@ -269,14 +269,8 @@ func (ob *mprWidgetObjectBuilder) CloneGallerySelectionProperty(propertyKey stri
 		return
 	}
 
-	ob.object = updateWidgetPropertyValue(ob.object, ob.propertyTypeIDs, propertyKey, func(val bson.D) bson.D {
-		// The val here is the WidgetValue — but we need the WidgetProperty level.
-		// CloneGallerySelectionProperty works on the Properties array directly.
-		return val
-	})
-
-	// Actually need to work at the Properties array level: find the property,
-	// clone it with new IDs and updated Selection, then append.
+	// Work at the Properties array level: find the property, clone it with new
+	// IDs and updated Selection, then append.
 	result := make(bson.D, 0, len(ob.object))
 	for _, elem := range ob.object {
 		if elem.Key == "Properties" {

mdl/backend/mpr/workflow_mutator.go

@@ -714,7 +714,11 @@ func collectNamesRecursive(flow bson.D, names map[string]bool) {
 // deduplicateNewActivityName ensures a new activity name doesn't conflict.
 func deduplicateNewActivityName(act workflows.WorkflowActivity, existingNames map[string]bool) {
 	name := act.GetName()
-	if name == "" || !existingNames[name] {
+	if name == "" {
+		return
+	}
+	if !existingNames[name] {
+		existingNames[name] = true
 		return
 	}
 	for i := 2; i < 1000; i++ {

mdl/executor/widget_engine.go

@@ -4,6 +4,7 @@ package executor
 
 import (
 	"fmt"
+	"sort"
 	"strings"
 
 	"github.com/mendixlabs/mxcli/mdl/ast"
@@ -173,6 +174,7 @@ func (e *PluggableWidgetEngine) Build(def *WidgetDefinition, w *ast.WidgetV3) (*
 			widgetsPropKeys = append(widgetsPropKeys, propKey)
 		}
 	}
+	sort.Strings(widgetsPropKeys)
 	// Phase 1: Named matching — match children by name against property keys
 	matchedChildren := make(map[int]bool)
 	for _, propKey := range widgetsPropKeys {