fix(lint): handle chained XPath predicates in stripXPathBrackets

[a = 1][b = 2] was incorrectly stripped to a = 1][b = 2 because
the check only looked at the first and last characters. The fix
walks bracket depth to confirm the opening [ at position 0 is
matched by the final ] before stripping.

Added two test cases for chained predicates.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R1yYeYn9rosf8UdAimdatt

Author: Andries-Smit

mdl/linter/starlark_xpath.go

@@ -13,10 +13,29 @@ import (
 
 // stripXPathBrackets removes the outer [ and ] from a Mendix XPath constraint string.
 // Returns the inner expression ready for parsing.
+// Only strips when the opening [ at position 0 is matched by the final ] (i.e. they
+// form a single outer pair). Chained predicates like [a = 1][b = 2] are returned as-is.
 func stripXPathBrackets(s string) string {
 	s = strings.TrimSpace(s)
-	if strings.HasPrefix(s, "[") && strings.HasSuffix(s, "]") {
-		return s[1 : len(s)-1]
+	if !strings.HasPrefix(s, "[") || !strings.HasSuffix(s, "]") {
+		return s
+	}
+	// Walk forward to find where the first '[' closes.
+	depth := 0
+	for i, ch := range s {
+		switch ch {
+		case '[':
+			depth++
+		case ']':
+			depth--
+			if depth == 0 {
+				if i == len(s)-1 {
+					return s[1 : len(s)-1]
+				}
+				// First '[' closes before the end — chained predicates; don't strip.
+				return s
+			}
+		}
 	}
 	return s
 }

mdl/linter/starlark_xpath_test.go

@@ -93,6 +93,9 @@ func TestStripXPathBrackets(t *testing.T) {
 		{"Status = 'Active'", "Status = 'Active'"},
 		{"  [foo]  ", "foo"},
 		{"", ""},
+		// Chained predicates must not be partially stripped.
+		{"[a = 1][b = 2]", "[a = 1][b = 2]"},
+		{"[a = 1][b = 2][c = 3]", "[a = 1][b = 2][c = 3]"},
 	}
 	for _, c := range cases {
 		got := stripXPathBrackets(c.in)