fix: infer ReferenceSet association retrieve list entity type

Symptom: list operations after compact association retrieves could write bare filter attributes as unqualified invalid attribute identifiers.

Root cause: ReferenceSet association retrieves registered their result type as a list of the association name instead of a list of the entity on the other side, so downstream member resolution had no entity context.

Fix: use association metadata to register the other endpoint entity for ReferenceSet retrieves, while retaining the previous fallback for unknown metadata.

Tests: added a ReferenceSet retrieve type regression and ran make test.

Author: hjothamendix

mdl/executor/cmd_microflows_builder_actions.go

@@ -329,6 +329,18 @@ func (fb *flowBuilder) addRetrieveAction(s *ast.RetrieveStmt) model.ID {
 						otherEntity = assocInfo.parentEntityQN
 					}
 					fb.varTypes[s.Variable] = otherEntity
+				} else if assocInfo != nil && assocInfo.Type == domainmodel.AssociationTypeReferenceSet {
+					// ReferenceSet traversal returns a list of the entity on the other side,
+					// not a list typed as the association itself.
+					otherEntity := assocInfo.childEntityQN
+					if startVarType == assocInfo.childEntityQN {
+						otherEntity = assocInfo.parentEntityQN
+					}
+					if otherEntity != "" {
+						fb.varTypes[s.Variable] = "List of " + otherEntity
+					} else {
+						fb.varTypes[s.Variable] = "List of " + assocQN
+					}
 				} else {
 					// ReferenceSet or unknown: returns a list
 					fb.varTypes[s.Variable] = "List of " + assocQN

mdl/executor/cmd_microflows_builder_retrieve_reverse_test.go

@@ -81,11 +81,38 @@ func TestAddRetrieveAction_ReverseReferenceNonPersistableParentUsesAssociationSo
 	}
 }
 
+func TestAddRetrieveAction_ReferenceSetRegistersOtherEntityListType(t *testing.T) {
+	fb := newRetrieveAssociationFlowBuilderWithType(domainmodel.AssociationTypeReferenceSet, domainmodel.AssociationOwnerBoth, true, true)
+	fb.varTypes["Parent"] = "Sample.Parent"
+
+	fb.addRetrieveAction(&ast.RetrieveStmt{
+		Variable:      "Children",
+		StartVariable: "Parent",
+		Source:        ast.QualifiedName{Module: "Sample", Name: "Parent_Child"},
+	})
+
+	action := onlyRetrieveAction(t, fb)
+	source, ok := action.Source.(*microflows.AssociationRetrieveSource)
+	if !ok {
+		t.Fatalf("reference-set retrieve source = %T, want AssociationRetrieveSource", action.Source)
+	}
+	if source.StartVariable != "Parent" || source.AssociationQualifiedName != "Sample.Parent_Child" {
+		t.Fatalf("association source = %#v", source)
+	}
+	if got := fb.varTypes["Children"]; got != "List of Sample.Child" {
+		t.Fatalf("result var type = %q, want List of Sample.Child", got)
+	}
+}
+
 func newRetrieveAssociationFlowBuilder(owner domainmodel.AssociationOwner) *flowBuilder {
 	return newRetrieveAssociationFlowBuilderWithPersistability(owner, true, true)
 }
 
 func newRetrieveAssociationFlowBuilderWithPersistability(owner domainmodel.AssociationOwner, parentPersistable, childPersistable bool) *flowBuilder {
+	return newRetrieveAssociationFlowBuilderWithType(domainmodel.AssociationTypeReference, owner, parentPersistable, childPersistable)
+}
+
+func newRetrieveAssociationFlowBuilderWithType(associationType domainmodel.AssociationType, owner domainmodel.AssociationOwner, parentPersistable, childPersistable bool) *flowBuilder {
 	moduleID := model.ID("sample-module")
 	parentID := model.ID("parent-entity")
 	childID := model.ID("child-entity")
@@ -113,7 +140,7 @@ func newRetrieveAssociationFlowBuilderWithPersistability(owner domainmodel.Assoc
 							Name:     "Parent_Child",
 							ParentID: parentID,
 							ChildID:  childID,
-							Type:     domainmodel.AssociationTypeReference,
+							Type:     associationType,
 							Owner:    owner,
 						},
 					},