Commit c4d8126
committed
fix: address PR #68 review — remove ANTLR visitors, fix error handling, clean up docs
- Regenerate ANTLR parser with -no-visitor flag, removing 2649 lines of
unused visitor code (mdlparser_base_visitor.go, mdlparser_visitor.go)
- Restore .interp and .tokens files that were accidentally deleted
- Fix opAttributeObjects silently discarding createAttributeObject errors
- Fix deepCloneTemplate errors ignored in 3 test sites
- Add warning logs in augmentFromMPK when clone/augment fails
- Remove Claude-specific design docs from docs/plans/
Addresses remaining items from @ako's second review on PR #68.1 parent 63bf7f9 commit c4d8126
12 files changed
Lines changed: 26 additions & 6608 deletions
File tree
- docs/plans
- mdl
- executor
- grammar
- parser
- sdk/widgets
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
338 | 339 | | |
339 | 340 | | |
340 | 341 | | |
341 | | - | |
342 | | - | |
343 | | - | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
344 | 346 | | |
| 347 | + | |
345 | 348 | | |
346 | 349 | | |
347 | 350 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments