Skip to content

Commit cafddad

Browse files
akoclaude
andcommitted
fix: match FileSystemProvider method signatures for editable documents
VS Code checks writeFile.length to determine if a FileSystemProvider supports writing. Our methods were missing required parameters (options objects), causing documents to open as read-only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 3e0e3fe commit cafddad

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

vscode-mdl/src/mdlContentProvider.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export class MdlFileSystemProvider implements vscode.FileSystemProvider {
4343
this.mprPath = configured || undefined;
4444
}
4545

46-
watch(): vscode.Disposable {
46+
watch(_uri: vscode.Uri, _options: { recursive: boolean; excludes: string[] }): vscode.Disposable {
4747
return new vscode.Disposable(() => {});
4848
}
4949

@@ -58,11 +58,11 @@ export class MdlFileSystemProvider implements vscode.FileSystemProvider {
5858
};
5959
}
6060

61-
readDirectory(): [string, vscode.FileType][] {
61+
readDirectory(_uri: vscode.Uri): [string, vscode.FileType][] {
6262
return [];
6363
}
6464

65-
createDirectory(): void {
65+
createDirectory(_uri: vscode.Uri): void {
6666
throw vscode.FileSystemError.NoPermissions('Cannot create directories');
6767
}
6868

@@ -92,7 +92,7 @@ export class MdlFileSystemProvider implements vscode.FileSystemProvider {
9292
return encoded;
9393
}
9494

95-
async writeFile(uri: vscode.Uri, content: Uint8Array): Promise<void> {
95+
async writeFile(uri: vscode.Uri, content: Uint8Array, _options: { create: boolean; overwrite: boolean }): Promise<void> {
9696
const mprFile = await this.findMprFile();
9797
if (!mprFile) {
9898
vscode.window.showErrorMessage('No .mpr file found. Set mdl.mprPath in settings.');
@@ -138,11 +138,11 @@ export class MdlFileSystemProvider implements vscode.FileSystemProvider {
138138
vscode.window.showInformationMessage('MDL changes applied to project.');
139139
}
140140

141-
delete(): void {
141+
delete(_uri: vscode.Uri, _options: { recursive: boolean }): void {
142142
throw vscode.FileSystemError.NoPermissions('Cannot delete');
143143
}
144144

145-
rename(): void {
145+
rename(_oldUri: vscode.Uri, _newUri: vscode.Uri, _options: { overwrite: boolean }): void {
146146
throw vscode.FileSystemError.NoPermissions('Cannot rename');
147147
}
148148

0 commit comments

Comments
 (0)