Merge branch 'issues'

Author: ako

.claude/commands/mxcli-dev/review.md

@@ -32,6 +32,8 @@ proactively. Add a row after every review that surfaces something new.
 | 7 | Skill/doc table references a function that doesn't exist (e.g. `formatActionStatement()` vs `formatAction()`) | Docs quality | Grep function names before writing: `grep -r "func formatA" mdl/executor/` |
 | 8 | "Always X" rule is too absolute for trivial edge cases (e.g. "always write failing test first" for one-char typos) | Docs quality | Soften to "prefer X" or add an exception clause; include the reasoning so readers can judge edge cases |
 | 9 | Doc comment promises a fallback/feature that doesn't exist in the code (e.g., "raw-map fallback in the client" when no such fallback was implemented) | Docs quality | Grep for function/type names referenced in doc comments to confirm they exist before committing |
+| 10 | BSON array items decoded by mongo driver are `primitive.D`, not `map[string]any` — bare type assertion `item.(map[string]any)` always fails silently, causing silent data loss (e.g. Languages not parsed, issue #480) | BSON parsing | Always use `extractBsonMap(item)` instead of `item.(map[string]any)`; write a parser unit test with `primitive.D` items to catch this class of bug |
+| 11 | `execShow` switch missing a case for a new `ShowXxx` constant — executor handler is wired but never dispatched, command silently does nothing | Dispatch gap | After adding a new `Show*` constant and handler, grep `executor_query.go` to confirm the case is present; add a mock test that calls the handler directly |
 
 ---
 

docs/01-project/MDL_QUICK_REFERENCE.md

@@ -457,6 +457,7 @@ create or replace navigation Responsive
 | Drop configuration | `drop configuration 'Name';` | Remove a configuration |
 | Alter language | `alter settings LANGUAGE key = value;` | DefaultLanguageCode |
 | Alter workflows | `alter settings workflows key = value;` | UserEntity, DefaultTaskParallelism |
+| List languages | `show languages;` | Lists language codes with translation string counts (requires `refresh catalog full`) |
 
 ## Business Events
 

mdl-examples/doctype-tests/14-project-settings-examples.mdl

@@ -145,5 +145,6 @@ alter settings workflows UserEntity = 'System.User';
 -- ALTER SETTINGS LANGUAGE
 -- ALTER SETTINGS WORKFLOWS
 -- SHOW SETTINGS / DESCRIBE SETTINGS (read-only)
+-- SHOW LANGUAGES (lists language codes with string counts; requires refresh catalog full)
 --
 -- ============================================================================

mdl/executor/cmd_languages_mock_test.go

@@ -0,0 +1,59 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package executor
+
+import (
+	"testing"
+
+	"github.com/mendixlabs/mxcli/mdl/catalog"
+)
+
+func TestListLanguages_NilCatalog(t *testing.T) {
+	ctx, _ := newMockCtx(t)
+	// Catalog is nil by default in newMockCtx
+	err := listLanguages(ctx)
+	assertError(t, err)
+}
+
+func TestListLanguages_EmptyStringsTable(t *testing.T) {
+	cat, err := catalog.New()
+	if err != nil {
+		t.Fatalf("failed to create catalog: %v", err)
+	}
+	defer cat.Close()
+
+	ctx, buf := newMockCtx(t)
+	ctx.Catalog = cat
+
+	assertNoError(t, listLanguages(ctx))
+	assertContainsStr(t, buf.String(), "No translatable strings found")
+}
+
+func TestListLanguages_WithRows(t *testing.T) {
+	cat, err := catalog.New()
+	if err != nil {
+		t.Fatalf("failed to create catalog: %v", err)
+	}
+	defer cat.Close()
+
+	db := cat.CatalogDB()
+	_, err = db.Exec(`INSERT INTO strings (QualifiedName, ObjectType, StringValue, StringContext, Language, ElementId, ModuleName) VALUES (?, ?, ?, ?, ?, ?, ?)`,
+		"MyModule.HomePage", "Page", "Hello", "Caption", "en_US", "id1", "MyModule")
+	if err != nil {
+		t.Fatalf("failed to seed strings table: %v", err)
+	}
+	_, err = db.Exec(`INSERT INTO strings (QualifiedName, ObjectType, StringValue, StringContext, Language, ElementId, ModuleName) VALUES (?, ?, ?, ?, ?, ?, ?)`,
+		"MyModule.HomePage", "Page", "Bonjour", "Caption", "fr_FR", "id2", "MyModule")
+	if err != nil {
+		t.Fatalf("failed to seed strings table: %v", err)
+	}
+
+	ctx, buf := newMockCtx(t)
+	ctx.Catalog = cat
+
+	assertNoError(t, listLanguages(ctx))
+	out := buf.String()
+	assertContainsStr(t, out, "en_US")
+	assertContainsStr(t, out, "fr_FR")
+	assertContainsStr(t, out, "Language")
+}

mdl/executor/executor_query.go

@@ -105,6 +105,8 @@ func execShow(ctx *ExecContext, s *ast.ShowStmt) error {
 		return listBusinessEvents(ctx, s.InModule)
 	case ast.ShowSettings:
 		return listSettings(ctx)
+	case ast.ShowLanguages:
+		return listLanguages(ctx)
 	case ast.ShowFragments:
 		return listFragments(ctx)
 	case ast.ShowDatabaseConnections:

model/types.go

@@ -815,7 +815,19 @@ type ConventionSettings struct {
 // LanguageSettings represents Settings$LanguageSettings.
 type LanguageSettings struct {
 	BaseElement
-	DefaultLanguageCode string `json:"defaultLanguageCode,omitempty"`
+	DefaultLanguageCode string     `json:"defaultLanguageCode,omitempty"`
+	Languages           []Language `json:"languages,omitempty"`
+}
+
+// Language represents a Texts$Language entry in the project language settings.
+// The Languages slice is populated by parseLanguageSettings and is available
+// for use by settings describers and future language-aware commands.
+type Language struct {
+	Code                 string `json:"code"`
+	CheckCompleteness    bool   `json:"checkCompleteness,omitempty"`
+	CustomDateFormat     string `json:"customDateFormat,omitempty"`
+	CustomDateTimeFormat string `json:"customDateTimeFormat,omitempty"`
+	CustomTimeFormat     string `json:"customTimeFormat,omitempty"`
 }
 
 // CertificateSettings represents Settings$CertificateSettings.

sdk/mpr/parser_settings.go

@@ -173,6 +173,19 @@ func parseLanguageSettings(raw map[string]any) *model.LanguageSettings {
 	ls.ID = model.ID(extractBsonID(raw["$ID"]))
 	ls.TypeName = extractString(raw["$Type"])
 	ls.DefaultLanguageCode = extractString(raw["DefaultLanguageCode"])
+	for _, item := range extractBsonArray(raw["Languages"]) {
+		langMap := extractBsonMap(item)
+		if langMap == nil {
+			continue
+		}
+		ls.Languages = append(ls.Languages, model.Language{
+			Code:                 extractString(langMap["Code"]),
+			CheckCompleteness:    extractBool(langMap["CheckCompleteness"], false),
+			CustomDateFormat:     extractString(langMap["CustomDateFormat"]),
+			CustomDateTimeFormat: extractString(langMap["CustomDateTimeFormat"]),
+			CustomTimeFormat:     extractString(langMap["CustomTimeFormat"]),
+		})
+	}
 	return ls
 }
 

sdk/mpr/parser_settings_test.go

@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: Apache-2.0
+
+package mpr
+
+import (
+	"testing"
+
+	"go.mongodb.org/mongo-driver/bson/primitive"
+)
+
+// TestParseLanguageSettings_Languages verifies that Languages array items stored
+// as primitive.D (the BSON decoded type) are correctly parsed via extractBsonMap.
+// This is the fix for issue #480: bare .(map[string]any) assertions always fail
+// on primitive.D values, so extractBsonMap must be used instead.
+func TestParseLanguageSettings_Languages(t *testing.T) {
+	raw := map[string]any{
+		"$ID":                 "settings-lang-1",
+		"$Type":               "Settings$LanguageSettings",
+		"DefaultLanguageCode": "en_US",
+		"Languages": primitive.A{
+			int32(2),
+			primitive.D{
+				{Key: "$ID", Value: "lang-1"},
+				{Key: "$Type", Value: "Texts$Language"},
+				{Key: "Code", Value: "en_US"},
+				{Key: "CheckCompleteness", Value: true},
+				{Key: "CustomDateFormat", Value: "MM/dd/yyyy"},
+				{Key: "CustomDateTimeFormat", Value: "MM/dd/yyyy HH:mm"},
+				{Key: "CustomTimeFormat", Value: "HH:mm"},
+			},
+			primitive.D{
+				{Key: "$ID", Value: "lang-2"},
+				{Key: "$Type", Value: "Texts$Language"},
+				{Key: "Code", Value: "fr_FR"},
+				{Key: "CheckCompleteness", Value: false},
+			},
+		},
+	}
+
+	ls := parseLanguageSettings(raw)
+
+	if ls.DefaultLanguageCode != "en_US" {
+		t.Errorf("DefaultLanguageCode = %q, want %q", ls.DefaultLanguageCode, "en_US")
+	}
+	if len(ls.Languages) != 2 {
+		t.Fatalf("len(Languages) = %d, want 2", len(ls.Languages))
+	}
+
+	en := ls.Languages[0]
+	if en.Code != "en_US" {
+		t.Errorf("Languages[0].Code = %q, want %q", en.Code, "en_US")
+	}
+	if !en.CheckCompleteness {
+		t.Errorf("Languages[0].CheckCompleteness = false, want true")
+	}
+	if en.CustomDateFormat != "MM/dd/yyyy" {
+		t.Errorf("Languages[0].CustomDateFormat = %q, want %q", en.CustomDateFormat, "MM/dd/yyyy")
+	}
+	if en.CustomDateTimeFormat != "MM/dd/yyyy HH:mm" {
+		t.Errorf("Languages[0].CustomDateTimeFormat = %q, want %q", en.CustomDateTimeFormat, "MM/dd/yyyy HH:mm")
+	}
+	if en.CustomTimeFormat != "HH:mm" {
+		t.Errorf("Languages[0].CustomTimeFormat = %q, want %q", en.CustomTimeFormat, "HH:mm")
+	}
+
+	fr := ls.Languages[1]
+	if fr.Code != "fr_FR" {
+		t.Errorf("Languages[1].Code = %q, want %q", fr.Code, "fr_FR")
+	}
+	if fr.CheckCompleteness {
+		t.Errorf("Languages[1].CheckCompleteness = true, want false")
+	}
+}
+
+// TestParseLanguageSettings_EmptyLanguages verifies that an absent or empty
+// Languages array results in a nil/empty slice without panicking.
+func TestParseLanguageSettings_EmptyLanguages(t *testing.T) {
+	raw := map[string]any{
+		"$ID":                 "settings-lang-2",
+		"$Type":               "Settings$LanguageSettings",
+		"DefaultLanguageCode": "en_US",
+		"Languages":           primitive.A{int32(2)},
+	}
+
+	ls := parseLanguageSettings(raw)
+	if len(ls.Languages) != 0 {
+		t.Errorf("len(Languages) = %d, want 0", len(ls.Languages))
+	}
+}