fix(tui): address code review feedback from PR #38

- Security: set socket permissions to 0600 after creation
- Fix CloseAgentListener to use pointer receiver
- Increase agent timeout from 60s to 120s (match documented socat -t 120)
- Cache filter history in memory to avoid disk reads on every keystroke
- Replace synthetic tea.KeyCtrlE with dedicated AgentAutoExecMsg
- Trim design doc from 902 lines to ~70 lines of design rationale

Author: engalar

cmd/mxcli/tui/agent_listener.go

@@ -36,6 +36,11 @@ func NewAgentListener(socketPath string, sendMsg func(tea.Msg), autoProceed bool
 	if err != nil {
 		return nil, err
 	}
+	// Restrict socket access to current user only
+	if err := os.Chmod(socketPath, 0600); err != nil {
+		ln.Close()
+		return nil, fmt.Errorf("chmod socket: %w", err)
+	}
 
 	al := &AgentListener{
 		socketPath:  socketPath,
@@ -150,7 +155,7 @@ func (al *AgentListener) handleConnection(conn net.Conn) {
 		select {
 		case resp := <-responseCh:
 			encoder.Encode(resp)
-		case <-time.After(60 * time.Second):
+		case <-time.After(120 * time.Second):
 			encoder.Encode(AgentResponse{ID: req.ID, OK: false, Error: "timeout waiting for TUI response"})
 		}
 	}

cmd/mxcli/tui/agent_msgs.go

@@ -42,6 +42,10 @@ type AgentCreateModuleMsg struct {
 	ResponseCh chan<- AgentResponse
 }
 
+// AgentAutoExecMsg triggers automatic MDL execution in ExecView
+// without simulating a keystroke. Used by auto-proceed mode.
+type AgentAutoExecMsg struct{}
+
 // Ensure messages satisfy tea.Msg.
 var (
 	_ tea.Msg = AgentExecMsg{}
@@ -50,4 +54,5 @@ var (
 	_ tea.Msg = AgentNavigateMsg{}
 	_ tea.Msg = AgentDeleteMsg{}
 	_ tea.Msg = AgentCreateModuleMsg{}
+	_ tea.Msg = AgentAutoExecMsg{}
 )

cmd/mxcli/tui/app.go

@@ -149,7 +149,7 @@ func (a *App) StartAgentListener(prog *tea.Program, socketPath string, autoProce
 }
 
 // CloseAgentListener stops the agent listener if running.
-func (a App) CloseAgentListener() {
+func (a *App) CloseAgentListener() {
 	if a.agentListener != nil {
 		a.agentListener.Close()
 	}
@@ -469,10 +469,7 @@ func (a App) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		ev := NewExecViewWithContent(a.mxcliPath, a.activeTabProjectPath(), a.width, a.height, msg.MDL)
 		a.views.Push(ev)
 		if a.agentAutoProceed {
-			// Auto-trigger execution (like pressing Ctrl+E)
-			return a, func() tea.Msg {
-				return tea.KeyMsg{Type: tea.KeyCtrlE}
-			}
+			return a, func() tea.Msg { return AgentAutoExecMsg{} }
 		}
 		return a, nil
 

cmd/mxcli/tui/execview.go

@@ -315,6 +315,14 @@ func (ev ExecView) Update(msg tea.Msg) (View, tea.Cmd) {
 		ev.textarea.SetHeight(msg.Height - 6)
 		return ev, nil
 
+	case AgentAutoExecMsg:
+		mdlText := strings.TrimSpace(ev.textarea.Value())
+		if mdlText == "" {
+			return ev, nil
+		}
+		ev.executing = true
+		return ev, ev.executeMDL(mdlText)
+
 	case tea.KeyMsg:
 		if ev.executing {
 			return ev, nil

cmd/mxcli/tui/filterhistory.go

@@ -12,13 +12,23 @@ import (
 
 const maxFilterHistory = 50
 
+// filterHistoryCache holds the in-memory cache of filter history entries.
+// Loaded once from disk, updated in memory and written back on mutation.
+var filterHistoryCache []string
+var filterHistoryCacheLoaded bool
+
 func filterHistoryPath() string {
 	home, _ := os.UserHomeDir()
 	return filepath.Join(home, ".mxcli", "tui-filter-history.json")
 }
 
 // LoadFilterHistory returns recent filter queries, most recent first.
+// Uses an in-memory cache to avoid disk reads on every keystroke.
 func LoadFilterHistory() []string {
+	if filterHistoryCacheLoaded {
+		return filterHistoryCache
+	}
+	filterHistoryCacheLoaded = true
 	data, err := os.ReadFile(filterHistoryPath())
 	if err != nil {
 		return nil
@@ -28,6 +38,7 @@ func LoadFilterHistory() []string {
 		Trace("filterhistory: unmarshal error: %v", err)
 		return nil
 	}
+	filterHistoryCache = entries
 	return entries
 }
 
@@ -43,6 +54,9 @@ func AddFilterHistoryEntry(query string) {
 	if len(entries) > maxFilterHistory {
 		entries = entries[:maxFilterHistory]
 	}
+	// Update in-memory cache
+	filterHistoryCache = entries
+	// Persist to disk
 	if err := os.MkdirAll(filepath.Dir(filterHistoryPath()), 0755); err != nil {
 		Trace("filterhistory: mkdir error: %v", err)
 		return