feat: add virtual System module for complete module listing#110
Merged
ako merged 1 commit intomendixlabs:mainfrom Apr 7, 2026
Merged
feat: add virtual System module for complete module listing#110ako merged 1 commit intomendixlabs:mainfrom
ako merged 1 commit intomendixlabs:mainfrom
Conversation
Add a virtual System module builder that provides System entities (User, Session, FileDocument, Image, etc.) and associations when listing modules and domain models. This enables catalog queries and reference resolution against System types without requiring them to exist in the MPR file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AI Code ReviewReview SummaryCritical IssuesNone found. Moderate Issues
Minor Issues
What Looks Good
RecommendationRequest changes primarily due to missing test coverage. Before approval:
The UUID conflict risk is theoretical and low impact (virtual module only appended to listings), but deterministic generation would be more consistent. The implementation quality is otherwise strong. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
4 tasks
ako
approved these changes
Apr 7, 2026
Collaborator
ako
left a comment
There was a problem hiding this comment.
Clean split from #107. Implementation is sound:
- Deterministic IDs via SHA-256 ensure stable System entity IDs across sessions
- Entity/association definitions extracted from Studio Pro 11.6.4
- Generalization hierarchy correctly handled (Image → FileDocument, etc.)
ListModules()andListDomainModels()integration is minimal and clean
Minor: No unit test for BuildSystemDomainModel() — a simple test verifying entity count and a few key entities would be nice but not blocking.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListModules()andListDomainModels()now include the System module for catalog queries and reference resolutionGenerateDeterministicID()utility for stable System entity IDsSplit from #107 per code review — this is an independent feature unrelated to ALTER WORKFLOW.
Test plan
go build ./...passesgo test ./...passesSHOW ENTITIESincludes System entities (User, Session, FileDocument, etc.)🤖 Generated with Claude Code