Skip to content

fix: docker cache detection on Windows and reload schema warning#160

Merged
ako merged 1 commit intomendixlabs:mainfrom
engalar:fix/docker-issues
Apr 9, 2026
Merged

fix: docker cache detection on Windows and reload schema warning#160
ako merged 1 commit intomendixlabs:mainfrom
engalar:fix/docker-issues

Conversation

@engalar
Copy link
Copy Markdown
Contributor

@engalar engalar commented Apr 9, 2026

Summary

Test plan

  • All existing docker package tests pass
  • New TestReload_ModelOnly_PendingDDL validates DDL warning output
  • TestReload_ModelOnly verifies both reload_model and get_ddl_commands actions are called
  • Verify get_ddl_commands response format against a live Mendix runtime (feedback field name: ddl_commands string)

Closes #126
Closes #115

🤖 Generated with Claude Code

Fix mendixlabs#126: CachedMxBuildPath/AnyCachedMxBuildPath/findMxBuildInDir now
check both "mxbuild.exe" and "mxbuild" on Windows, so the Linux binary
cached for Docker is found without re-downloading the 394MB tarball.

Fix mendixlabs#115: After reload_model succeeds, call get_ddl_commands to detect
pending schema changes. If DDL is pending, print a warning with the
actual DDL text and suggest using 'docker up --fresh'.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

AI Code Review

What Looks Good

  • Windows caching fix: Correctly addresses the root cause by checking both mxbuild.exe and mxbuild on Windows Docker environments where the Linux binary is cached
  • DDL warning after reload: Proactively prevents runtime crashes by checking for pending schema changes and providing clear remediation guidance (mxcli docker up --fresh)
  • Test improvements: New test validates DDL warning output; existing tests updated to verify correct action sequence
  • Helper function: mxbuildBinaryNames() extraction reduces duplication and clarifies intent
  • Backwards compatibility: Changes are additive and don't break existing functionality
  • Clear documentation: Comments explain why checks are necessary for both fixes

Recommendation

Approve the PR. The changes are well-scoped, properly tested, address real user issues (unnecessary downloads and silent failures), and follow existing code patterns. No blocking issues found. The minor incomplete test item (verifying against live Mendix runtime) is appropriately acknowledged as needing feedback but unit tests adequately mock the HTTP interaction.


Automated review via OpenRouter (Nemotron Super 120B) — workflow source

@ako ako merged commit 2c71231 into mendixlabs:main Apr 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mxcli docker run re-downloads MxBuild on Windows even when Linux binary already exists docker reload silently fails for new entities (no schema sync)

2 participants