fix: docker cache detection on Windows and reload schema warning#160
Merged
ako merged 1 commit intomendixlabs:mainfrom Apr 9, 2026
Merged
fix: docker cache detection on Windows and reload schema warning#160ako merged 1 commit intomendixlabs:mainfrom
ako merged 1 commit intomendixlabs:mainfrom
Conversation
Fix mendixlabs#126: CachedMxBuildPath/AnyCachedMxBuildPath/findMxBuildInDir now check both "mxbuild.exe" and "mxbuild" on Windows, so the Linux binary cached for Docker is found without re-downloading the 394MB tarball. Fix mendixlabs#115: After reload_model succeeds, call get_ddl_commands to detect pending schema changes. If DDL is pending, print a warning with the actual DDL text and suggest using 'docker up --fresh'.
AI Code ReviewWhat Looks Good
RecommendationApprove the PR. The changes are well-scoped, properly tested, address real user issues (unnecessary downloads and silent failures), and follow existing code patterns. No blocking issues found. The minor incomplete test item (verifying against live Mendix runtime) is appropriately acknowledged as needing feedback but unit tests adequately mock the HTTP interaction. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mxcli docker runon Windows re-downloads MxBuild (~394MB) even when the Linux binary is already cached. Root cause: cache check looked formxbuild.exebut Docker needsmxbuild. Now checks both names on Windows.docker reloadsilently succeeds when new entities are added, but the app crashes at runtime ("Entity does not exist") because the database schema wasn't synced. Now callsget_ddl_commandsafter reload and prints a warning with pending DDL text if schema changes are detected.Test plan
dockerpackage tests passTestReload_ModelOnly_PendingDDLvalidates DDL warning outputTestReload_ModelOnlyverifies bothreload_modelandget_ddl_commandsactions are calledget_ddl_commandsresponse format against a live Mendix runtime (feedback field name:ddl_commandsstring)Closes #126
Closes #115
🤖 Generated with Claude Code