Skip to content

Misc#269

Merged
ako merged 2 commits intomainfrom
misc
Apr 22, 2026
Merged

Misc#269
ako merged 2 commits intomainfrom
misc

Conversation

@ako
Copy link
Copy Markdown
Collaborator

@ako ako commented Apr 22, 2026

No description provided.

ako and others added 2 commits April 22, 2026 19:20
The execHelp function signature was updated to accept a *ast.HelpStmt
for topic-based help. Update the mock test to pass an empty HelpStmt
so the call matches the two-argument signature.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bsent)

System.UserGroup does not exist in the integration test Mendix version,
so the retrieve activity in ACT_GetGroups produces CE1613. Add it to
the known-errors allowlist so the doctype test passes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ako ako merged commit 75a2a7f into main Apr 22, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

AI Code Review

Critical Issues

None found.

Moderate Issues

None found.

Minor Issues

None found.

What Looks Good

  • The test fix in cmd_misc_mock_test.go correctly passes an &ast.HelpStmt{} to execHelp(), aligning the test with the function signature and improving test accuracy.
  • The addition to scriptKnownCEErrors in roundtrip_doctype_test.go appropriately documents a known CE1613 error for workflow-user-targeting.mdl due to missing System.UserGroup in the test Mendix version, preventing false test failures.
  • Both changes are scoped to test improvements without altering production code, maintaining clean separation.

Recommendation

Approve the changes. The modifications enhance test reliability and correctness without introducing risks or violating any checklist principles. No further action is needed.


Automated review via OpenRouter (Nemotron Super 120B) — workflow source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant