fix: correct microflow body syntax in bug-test 258#270
Open
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Open
fix: correct microflow body syntax in bug-test 258#270hjotha wants to merge 1 commit intomendixlabs:mainfrom
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Conversation
The bug-test script shipped with PR mendixlabs#258 used the old paren-body microflow form ('create microflow X returns Y (...)'), which the current MDL parser rejects. Studio Pro verification via 'mxcli check' fails before the script can even be executed. Rewrite the two microflows with the begin/end form so the script round-trips through check + exec. Functional payload (DROP + CREATE OR MODIFY with the same qualified name + DESCRIBE roundtrip) is unchanged. Verified: 'mxcli check mdl-examples/bug-tests/258-drop-create-microflow-unitid-preservation.mdl' reports 'Syntax OK (5 statements)'.
AI Code ReviewWhat Looks Good
RecommendationApprove the PR. The changes are minimal, targeted, and restore the bug-test script to a working state without altering its intended purpose. No checklist violations are identified. Automated review via OpenRouter (Nemotron Super 120B) — workflow source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The bug-test script that shipped with #258 (
mdl-examples/bug-tests/258-drop-create-microflow-unitid-preservation.mdl) used the legacy paren-body microflow form:The current MDL parser only accepts the
begin ... end;form — the script failsmxcli checkbefore it can ever be executed. Script is defanged as a regression artifact until the body is fixed.This PR rewrites the two microflows with the
begin/endform so the script parses. The functional payload —DROP MICROFLOW, thenCREATE OR MODIFY MICROFLOWwith the same qualified name to exerciseUnitIDpreservation, thenDESCRIBEto verify the roundtrip — is unchanged.Test plan
mxcli check mdl-examples/bug-tests/258-drop-create-microflow-unitid-preservation.mdlreportsSyntax OK (5 statements).go build ./... && go test ./...pass.