fix(docs-site): remove duplicated src/ in GitHub edit link#733
Merged
Conversation
…plate
mdBook resolves {path} relative to the book root (docs-site/), which
already includes the src/ prefix, so the template was producing
.../docs-site/src/src/<page> instead of .../docs-site/src/<page>.
This was referenced Jul 4, 2026
ako
approved these changes
Jul 7, 2026
ako
left a comment
ako
left a comment
Collaborator
There was a problem hiding this comment.
Verified locally: building docs-site with the current template produces edit links with a duplicated src (.../docs-site/src/src/...) — in mdBook v0.5.2 the {path} placeholder already includes the src/ prefix. This fix (docs-site/{path}) resolves to the correct file path (e.g. docs-site/src/appendixes/changelog.md), fixing the broken "Suggest an Edit" link. Thanks!
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Suggest an Edit" button Top right on the documentation site does not work.
https://www.mxcli.org/
Summary
.../edit/main/docs-site/src/src/<page>(duplicatedsrc) instead of.../edit/main/docs-site/src/<page>.{path}inedit-url-templaterelative to the book root (docs-site/), which already includes thesrc/prefix — so the template's hardcodeddocs-site/src/{path}doubled it up.docs-site/{path}indocs-site/book.toml.Test plan
mdbook build docs-site(ormdbook serve docs-site) and confirm the "Edit this page" link on a page (e.g. migration README) now points to.../edit/main/docs-site/src/migration/README.mdwith no duplicatedsrc.