Skip to content

Commit f649962

Browse files
committed
[analytics-engine] Centralize CalciteAliasFieldAggregationIT exclude in build.gradle
Per review: keep all AE-route test exclusions in one place. Move the inline Assume.assumeFalse(isAnalyticsParquetIndicesEnabled()) guard out of CalciteAliasFieldAggregationIT into the gated analyticsEnabled exclude block in integ-test/build.gradle, alongside the other doomed PPL ITs. The rationale (raw-PUT alias index can't be created on the AE route) is carried into both the build.gradle comment and a short note left at the test's init(). Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
1 parent ab4e7c6 commit f649962

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

integ-test/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1079,6 +1079,9 @@ task integTestRemote(type: RestIntegTestTask) {
10791079
excludeTestsMatching 'org.opensearch.sql.ppl.SystemFunctionIT.typeof_opensearch_types'
10801080
// alias_index_mapping: alias_col is type=alias; query is `where alias_col > 1`.
10811081
excludeTestsMatching 'org.opensearch.sql.ppl.DataTypeIT.test_alias_data_type'
1082+
// CalciteAliasFieldAggregationIT: raw-PUT alias index can't be created on the AE route
1083+
// and every test queries alias fields directly — whole class doomed.
1084+
excludeTestsMatching 'org.opensearch.sql.calcite.remote.CalciteAliasFieldAggregationIT'
10821085
}
10831086
}
10841087

integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAliasFieldAggregationIT.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
import java.io.IOException;
1616
import java.util.List;
1717
import org.json.JSONObject;
18-
import org.junit.Assume;
1918
import org.junit.jupiter.api.Test;
2019
import org.opensearch.client.Request;
2120
import org.opensearch.client.ResponseException;
@@ -32,12 +31,9 @@ public class CalciteAliasFieldAggregationIT extends PPLIntegTestCase {
3231
@Override
3332
public void init() throws Exception {
3433
super.init();
35-
// Alias fields are unsupported on the analytics-engine (parquet/composite) route — the index
36-
// can't even be created, and these tests query the alias fields directly. There's nothing to
37-
// salvage by stripping, so skip the whole class on the AE route. Runs normally otherwise.
38-
Assume.assumeFalse(
39-
"Alias-field aggregation is unsupported on the analytics-engine route",
40-
isAnalyticsParquetIndicesEnabled());
34+
// Excluded on the analytics-engine route from integ-test/build.gradle (alias fields are
35+
// unsupported there — the raw-PUT index can't even be created and these tests query the alias
36+
// fields directly), alongside the other AE-route exclusions kept in one place.
4137
enableCalcite();
4238
createTestIndexWithAliasFields();
4339
loadIndex(Index.DATA_TYPE_ALIAS);

0 commit comments

Comments
 (0)