feat: Add custom encoding support (CP949, CP936, UTF-16) and fix encoding/rendering bugs#49
Closed
stdust wants to merge 4 commits into
Closed
feat: Add custom encoding support (CP949, CP936, UTF-16) and fix encoding/rendering bugs#49stdust wants to merge 4 commits into
stdust wants to merge 4 commits into
Conversation
…& fix input/panic/boundary bugs
stdust
force-pushed
the
feat/custom-encoding
branch
from
July 15, 2026 09:15
345e366 to
8ed153a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for custom encodings (CP949, CP936, UTF-16 LE/BE) to the Hex view's ASCII panel. It also fixes file corruption issues caused by unmappable characters, and resolves rendering/panic bugs related to multi-byte characters spanning across 16-byte row boundaries.
Changes
dialog_encoding.rs): Added CP949, CP936, and UTF-16 encodings to the selection list.draw.rs): Rewrote the ASCII hex rendering function to decode the entire page buffer at once instead of decoding per-line. This prevents multi-byte characters that span row boundaries from getting split and garbled.util.rs/edit.rs): Preventedencoding_rsfrom inserting HTML entities (like안) into the file when typing unmappable characters. Now it cleanly writes a single?replacement byte instead.