feat: Add custom encoding support (CP949, CP936, UTF-16) and fix encoding/rendering bugs#50
Open
stdust wants to merge 4 commits into
Open
feat: Add custom encoding support (CP949, CP936, UTF-16) and fix encoding/rendering bugs#50stdust wants to merge 4 commits into
stdust wants to merge 4 commits into
Conversation
…& fix input/panic/boundary bugs
Member
|
Hi. I appreciate your willing to help. I have a few comments/questions.
Please notice we don't accept vibe-coded PRs. See https://github.com/mentebinaria/dz6?tab=contributing-ov-file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added custom encoding support (including CP949, CP936, UTF-16 LE/BE) to hex view ASCII panel using Paragraph widget to prevent character clipping, dynamically positioning the select dialog based on terminal height, and fixed keyboard input and out of bounds panics for small files.
Key Changes
height / 12offset) rather than using a hardcoded value, preventing layout clipping.draw.rs/dialog_encoding.rs): Refactored the ASCII draw function to decode the entire page space instead of decoding per-line. This prevents multi-byte characters that span row boundaries from getting split and garbled.util.rs/edit.rs): Preventedencoding_rsfrom inserting HTML entities (like안) into the file when typing unmappable characters. Now it cleanly writes a single?replacement byte instead.