This repository was archived by the owner on Feb 10, 2022. It is now read-only.
Country support and improvements#11
Open
Luciano Becerra (lubc) wants to merge 7 commits into
Open
Conversation
Ernesto Tagwerker (etagwerker)
approved these changes
Oct 19, 2016
Ernesto Tagwerker (etagwerker)
left a comment
Ernesto Tagwerker (etagwerker)
left a comment
There was a problem hiding this comment.
These changes look good! 👍
Author
|
Raphael Maurício Cerqueira (@Phaael) Rafael Prenzier (@prenzier) Could you review this? Thanks! |
|
Thanks bro! |
|
Why are taken so long to merge this thing up? I just cant solve the problem with the BR redirection. |
|
This is so frustrating, I'm trying to build something with mercadolibre could someone from ML please, merge this wonderful PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR fixes the issue #10 and also adds some improvements.
All the changes:
auth_urlmethodconfig.ymlfile and declares all the constants inlib/constants.rbspec/meli_spec.rband adds coverage forauth_urlREADME.md