fix(listener): record gha_job_queue_duration_seconds from JobAvailable#25
Open
evanclan wants to merge 1 commit into
Open
Conversation
GitHub does not populate QueueTime on JobStarted messages, so stash the queue time when JobAvailable is received and emit the histogram when the matching job starts. Fixes the broken metric added in mercari#19 and aligns with the approach from closed PR mercari#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gha_job_queue_duration_secondsso it records meaningful values instead of always emitting zeroQueueTimeonJobStartedmessages; queue time is now captured whenJobAvailableis received and matched byRunnerRequestIDwhen the job startsThis addresses the bug in #19 and implements the approach from closed PR #23 (without the temporary debug logging).
Test plan
TestJobQueueDurationMetricincmd/ghalistener/metrics/metrics_test.goMade with Cursor