feat: merge RFC 7986 COLOR property for calendar components#321
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
7112605 to
f4238f4
Compare
niccokunzmann
requested changes
Feb 24, 2026
f4238f4 to
15ff033
Compare
15ff033 to
58fded2
Compare
SashankBhamidi
commented
Feb 24, 2026
SashankBhamidi
commented
Feb 24, 2026
niccokunzmann
requested changes
Feb 24, 2026
10 tasks
niccokunzmann
requested changes
Feb 24, 2026
Collaborator
niccokunzmann
left a comment
There was a problem hiding this comment.
Just a little change and that is it.
Documenting intention and not code.
10 tasks
niccokunzmann
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
RFC 7986 §5.9 defines
COLORas a CSS3 color name that can appear onVCALENDAR,VEVENT,VTODO, andVJOURNAL. Apple extends this withX-APPLE-CALENDAR-COLORat the calendar level.This propagates the source calendar's resolved color to any component that lacks its own
COLOR. When merging multiple calendars, the first calendar with a color wins for the mergedVCALENDARtop-level property. Components that already declareCOLORare left untouched.Bumps
icalendarto>=7.0.0to use the typed.colorAPI (requires Python 3.10+). Also fixes latent UID-less deduplication bugs forVTODOandVJOURNALcomponents.