Skip to content

Commit f0cda66

Browse files
committed
correct memset
1 parent ae39b31 commit f0cda66

3 files changed

Lines changed: 12 additions & 15 deletions

File tree

src/glm_mcmc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ SEXP glm_mcmc(SEXP Y, SEXP X, SEXP Roffset, SEXP Rweights,
100100
SET_STRING_ELT(ANS_names, 8, mkChar("mle.se"));
101101

102102
SEXP shrinkage = allocVector(REALSXP, nModels);
103-
memset(REAL(shrinkage), 0.0, sizeof(double) *nModels);
103+
memset(REAL(shrinkage), 0.0, sizeof(double) *nModels);
104104
SET_VECTOR_ELT(ANS, 9, shrinkage);
105105
SET_STRING_ELT(ANS_names, 9, mkChar("shrinkage"));
106106

src/glm_mcmc_grow.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ SEXP glm_mcmc_grow(SEXP Y, SEXP X, SEXP Roffset, SEXP Rweights,
9292
SET_STRING_ELT(ANS_names, 12, mkChar("freq"));
9393

9494
SEXP MCMCprobs= duplicate(Rprobinit);
95-
memset(REAL(MCMCprobs), 0, nModels * sizeof(double));
9695
SET_VECTOR_ELT(ANS, 13, MCMCprobs);
9796
SET_STRING_ELT(ANS_names, 13, mkChar("probne0.MCMC"));
9897

src/lm_amcmc_growable.c

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -37,22 +37,27 @@ SEXP amcmc_grow(SEXP Y, SEXP X, SEXP Rweights, SEXP Rprobinit, SEXP RnModels,
3737
SET_STRING_ELT(ANS_names, 1, mkChar("which"));
3838

3939
SEXP Rlogmarg = allocVector(REALSXP, nModels);
40+
memset(REAL(Rlogmarg), 0.0, sizeof(double) *nModels);
4041
SET_VECTOR_ELT(ANS, 2, Rlogmarg);
4142
SET_STRING_ELT(ANS_names, 2, mkChar("logmarg"));
4243

4344
SEXP modelprobs = allocVector(REALSXP, nModels);
45+
memset(REAL(modelprobs), 0.0, sizeof(double) *nModels);
4446
SET_VECTOR_ELT(ANS, 3, modelprobs);
4547
SET_STRING_ELT(ANS_names, 3, mkChar("postprobs"));
4648

4749
SEXP priorprobs = allocVector(REALSXP, nModels);
50+
memset(REAL(priorprobs), 0.0, sizeof(double) *nModels);
4851
SET_VECTOR_ELT(ANS, 4, priorprobs);
4952
SET_STRING_ELT(ANS_names, 4, mkChar("priorprobs"));
5053

5154
SEXP sampleprobs = allocVector(REALSXP, nModels);
55+
memset(REAL(sampleprobs), 0.0, sizeof(double) *nModels);
5256
SET_VECTOR_ELT(ANS, 5, sampleprobs);
5357
SET_STRING_ELT(ANS_names, 5, mkChar("sampleprobs"));
5458

5559
SEXP mse = allocVector(REALSXP, nModels);
60+
memset(REAL(mse), 0.0, sizeof(double) *nModels);
5661
SET_VECTOR_ELT(ANS, 6, mse);
5762
SET_STRING_ELT(ANS_names, 6, mkChar("mse"));
5863

@@ -65,23 +70,28 @@ SEXP amcmc_grow(SEXP Y, SEXP X, SEXP Rweights, SEXP Rprobinit, SEXP RnModels,
6570
SET_STRING_ELT(ANS_names, 8, mkChar("mle.se"));
6671

6772
SEXP shrinkage = allocVector(REALSXP, nModels);
73+
memset(REAL(shrinkage), 0.0, sizeof(double) *nModels);
6874
SET_VECTOR_ELT(ANS, 9, shrinkage);
6975
SET_STRING_ELT(ANS_names, 9, mkChar("shrinkage"));
7076

7177
SEXP modeldim = allocVector(INTSXP, nModels);
78+
memset(INTEGER(modeldim), 0, nModels * sizeof(int));
7279
SET_VECTOR_ELT(ANS, 10, modeldim);
7380
SET_STRING_ELT(ANS_names, 10, mkChar("size"));
7481

7582
SEXP R2 = allocVector(REALSXP, nModels);
83+
memset(REAL(R2), 0.0, sizeof(double) *nModels);
7684
SET_VECTOR_ELT(ANS, 11, R2);
7785
SET_STRING_ELT(ANS_names, 11, mkChar("R2"));
7886

7987
SEXP rank = allocVector(INTSXP, nModels);
88+
memset(INTEGER(rank), 0, nModels * sizeof(int));
8089
SET_VECTOR_ELT(ANS, 12, rank);
8190
SET_STRING_ELT(ANS_names, 12, mkChar("rank"));
8291

8392
SEXP Rcounts = allocVector(INTSXP, nModels);
8493
counts = INTEGER(Rcounts);
94+
memset(counts, 0, nModels * sizeof(int));
8595
SET_VECTOR_ELT(ANS, 13, Rcounts);
8696
SET_STRING_ELT(ANS_names, 13, mkChar("freq"));
8797

@@ -92,19 +102,7 @@ SEXP amcmc_grow(SEXP Y, SEXP X, SEXP Rweights, SEXP Rprobinit, SEXP RnModels,
92102
SEXP NumUnique = allocVector(INTSXP, 1);
93103
SET_VECTOR_ELT(ANS, 15, NumUnique);
94104
SET_STRING_ELT(ANS_names, 15, mkChar("n.Unique"));
95-
96-
memset(REAL(Rlogmarg), 0.0, sizeof(double) *nModels);
97-
memset(REAL(modelprobs), 0.0, sizeof(double) *nModels);
98-
memset(REAL(priorprobs), 0.0, sizeof(double) *nModels);
99-
memset(REAL(shrinkage), 0.0, sizeof(double) *nModels);
100-
memset(REAL(R2), 0.0, sizeof(double) *nModels);
101-
memset(REAL(Rlogmarg), 0.0, sizeof(double) *nModels);
102-
memset(REAL(sampleprobs), 0.0, sizeof(double) *nModels);
103-
memset(INTEGER(modeldim), 0, sizeof(int) *nModels);
104-
memset(counts, 0, sizeof(int) *nModels);
105-
memset(REAL(mse), 0.0, sizeof(double) *nModels);
106-
memset(INTEGER(rank), 0, sizeof(int) *nModels);
107-
105+
108106

109107
setAttrib(ANS, R_NamesSymbol, ANS_names);
110108

0 commit comments

Comments
 (0)