Merge pull request #1633 from weebl2000/fix/gps-uart-power-leak

liamcottle · web-flow · commit d7ad89046be7 · 2026-03-03T23:26:58.000+13:00
Fix GPS UART consuming +8mA when disabled (nRF52)
diff --git a/src/helpers/sensors/EnvironmentSensorManager.cpp b/src/helpers/sensors/EnvironmentSensorManager.cpp
@@ -707,7 +707,9 @@ void EnvironmentSensorManager::loop() {
   static long next_gps_update = 0;
 
   #if ENV_INCLUDE_GPS
-  _location->loop();
+  if (gps_active) {
+    _location->loop();
+  }
   if (millis() > next_gps_update) {
 
     if(gps_active){
diff --git a/src/helpers/sensors/MicroNMEALocationProvider.h b/src/helpers/sensors/MicroNMEALocationProvider.h
@@ -79,7 +79,10 @@ public :
         if (_pin_en != -1) {
             digitalWrite(_pin_en, !PIN_GPS_EN_ACTIVE);
         }
-        if (_peripher_power) _peripher_power->release();  
+        if (_pin_reset != -1) {
+            digitalWrite(_pin_reset, GPS_RESET_FORCE);
+        }
+        if (_peripher_power) _peripher_power->release();
     }
 
     bool isEnabled() override {

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,10 @@ public :`
`79`	`79`	`if (_pin_en != -1) {`
`80`	`80`	`digitalWrite(_pin_en, !PIN_GPS_EN_ACTIVE);`
`81`	`81`	`}`
`82`		`- if (_peripher_power) _peripher_power->release();`
	`82`	`+ if (_pin_reset != -1) {`
	`83`	`+ digitalWrite(_pin_reset, GPS_RESET_FORCE);`
	`84`	`+ }`
	`85`	`+ if (_peripher_power) _peripher_power->release();`
`83`	`86`	`}`
`84`	`87`
`85`	`88`	`bool isEnabled() override {`