-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Model Generator includes status: enabled unnecessarily #17918
Copy link
Copy link
Open
meshery/meshkit
#951Labels
area/modelsModels, Components, Relationships related changesModels, Components, Relationships related changescomponent/mesheryctlCLI for MesheryCLI for Mesheryhelp wantedExtra attention is neededExtra attention is neededkind/enhancementImprovement in current featureImprovement in current featurelanguage/goIssues or pull requests that use GolangIssues or pull requests that use Golang
Metadata
Metadata
Assignees
Labels
area/modelsModels, Components, Relationships related changesModels, Components, Relationships related changescomponent/mesheryctlCLI for MesheryCLI for Mesheryhelp wantedExtra attention is neededExtra attention is neededkind/enhancementImprovement in current featureImprovement in current featurelanguage/goIssues or pull requests that use GolangIssues or pull requests that use Golang
Type
Fields
Give feedbackNo fields configured for issues without a type.
Current Behavior
Freshly generated components carry
status: enabledin their json definitionsDesired Behavior
Update model generation logic in https://github.com/meshery/meshkit function to avoid the unnecessary overhead of including
status: enabled, when this is already the default behavior. There's no need to explicitly include duplicative property and value of the default behavior.Implementation
Acceptance Tests
mesheryctl registry generateproduces components without thisstatusproperty.Contributor Guides and Handbook