registry: correct meshmodel fallback to meshery/models#1041
Conversation
The model data directory relocates to the meshery repo root as meshery/models (not meshery/server/models). Point the ProcessRelationships fallback at ../../meshery/models so relationship version resolution reads from the correct location when no explicit path is supplied. Signed-off-by: Ahmed Jamil <197998703+CodeAhmedJamil@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default path in the ProcessRelationships function of registry/relationship.go from ../../meshery/server/models to ../../meshery/models when the path parameter is empty. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
Updates MeshKit’s Meshery filesystem fallback so relationship processing resolves model versions from the new canonical Meshery on-disk directory (meshery/models at repo root), correcting the prior assumption from #1040.
Changes:
- Adjust
registry.ProcessRelationshipsdefault/fallback path from../../meshery/server/modelsto../../meshery/models.
Follow-up correction to #1040.
The meshery model data directory is relocating to the repo root as
meshery/models- notmeshery/server/modelsas the prior PR assumed. This points theProcessRelationshipsfallback (registry/relationship.go:115) at../../meshery/models.This is the only filesystem reference to the relocated directory in MeshKit; the
…/meshkit/models/meshmodel/…Go import paths are unrelated and unaffected.