fix: Resolve lint errors and warnings

- Wrap StateFlow.value read in remember{} to satisfy composition lint
- Wrap derivedStateOf in remember{} (MapView PurgeTileSourceDialog)
- Use mutableIntStateOf to avoid autoboxing (MapStyleDialog)
- Use ResourcesCompat.getDrawable() instead of deprecated getDrawable()
- Fix mixed indentation in MarkerClusterer.java

Lint result: 0 errors, 10 warnings (down from 2 errors, 12 warnings)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesarich

androidApp/src/fdroid/java/org/meshtastic/app/map/cluster/MarkerClusterer.java

@@ -127,8 +127,8 @@ protected void hideInfoWindows(){
 		int zoomLevel = mapView.getZoomLevel();
 		if (zoomLevel != mLastZoomLevel && !mapView.isAnimating()){
 			hideInfoWindows();
-        	mClusters = clusterer(mapView);
-        	renderer(mClusters, canvas, mapView);
+			mClusters = clusterer(mapView);
+			renderer(mClusters, canvas, mapView);
 			mLastZoomLevel = zoomLevel;
 		}
 

androidApp/src/fdroid/java/org/meshtastic/app/map/cluster/RadiusMarkerClusterer.java

@@ -27,6 +27,8 @@
 import android.graphics.drawable.Drawable;
 import android.view.MotionEvent;
 
+import androidx.core.content.res.ResourcesCompat;
+
 import org.meshtastic.app.map.model.MarkerWithLabel;
 
 import org.osmdroid.bonuspack.R;
@@ -72,7 +74,7 @@ public RadiusMarkerClusterer(Context ctx) {
         mTextPaint.setFakeBoldText(true);
         mTextPaint.setTextAlign(Paint.Align.CENTER);
         mTextPaint.setAntiAlias(true);
-        Drawable clusterIconD = ctx.getResources().getDrawable(R.drawable.marker_cluster);
+        Drawable clusterIconD = ResourcesCompat.getDrawable(ctx.getResources(), R.drawable.marker_cluster, ctx.getTheme());
         Bitmap clusterIcon = ((BitmapDrawable) clusterIconD).getBitmap();
         setIcon(clusterIcon);
         mAnimated = true;

androidApp/src/fdroid/kotlin/org/meshtastic/app/map/MapView.kt

@@ -52,6 +52,7 @@ import androidx.compose.runtime.derivedStateOf
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableDoubleStateOf
 import androidx.compose.runtime.mutableFloatStateOf
+import androidx.compose.runtime.mutableIntStateOf
 import androidx.compose.runtime.mutableStateListOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
@@ -825,15 +826,15 @@ private fun FdroidMainMapFilterDropdown(
 
 @Composable
 private fun MapStyleDialog(selectedMapStyle: Int, onDismiss: () -> Unit, onSelectMapStyle: (Int) -> Unit) {
-    val selected = remember { mutableStateOf(selectedMapStyle) }
+    val selected = remember { mutableIntStateOf(selectedMapStyle) }
 
     MapsDialog(onDismiss = onDismiss) {
         CustomTileSource.mTileSources.values.forEachIndexed { index, style ->
             ListItem(
                 text = style,
-                trailingIcon = if (index == selected.value) MeshtasticIcons.Check else null,
+                trailingIcon = if (index == selected.intValue) MeshtasticIcons.Check else null,
                 onClick = {
-                    selected.value = index
+                    selected.intValue = index
                     onSelectMapStyle(index)
                     onDismiss()
                 },
@@ -886,7 +887,7 @@ private fun PurgeTileSourceDialog(onDismiss: () -> Unit) {
     val context = LocalContext.current
     val cache = SqlTileWriterExt()
 
-    val sourceList by derivedStateOf { cache.sources.map { it.source as String } }
+    val sourceList by remember { derivedStateOf { cache.sources.map { it.source as String } } }
 
     val selected = remember { mutableStateListOf<Int>() }
 

androidApp/src/main/kotlin/org/meshtastic/app/ui/Main.kt

@@ -24,6 +24,7 @@ import androidx.compose.foundation.layout.safeDrawingPadding
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import androidx.navigation3.runtime.NavKey
@@ -57,12 +58,13 @@ fun MainScreen() {
     val viewModel: UIViewModel = koinViewModel()
     // Land on Connections for first-run / no-device-selected; otherwise on Nodes. Read synchronously
     // from the StateFlow (seeded from persisted prefs) so the initial tab is set in one shot.
-    val initialTab =
+    val initialTab = remember {
         if (viewModel.currentDeviceAddressFlow.value.isNullOrSelectedNone()) {
             TopLevelDestination.Connect.route
         } else {
             NodesRoute.Nodes
         }
+    }
     val multiBackstack = rememberMultiBackstack(initialTab)
     val backStack = multiBackstack.activeBackStack