refactor: remove ServiceBroadcasts + CommonParcelable infrastructure

Remove the entire ATAK broadcast intent and CommonParcelable infrastructure,
as TAK integration now uses the built-in TAK server.

Deleted files:
- Parcelable expect/actual declarations (common, android, jvm)
- ServiceBroadcasts interface and Android implementation
- Constants.kt broadcast action constants
- ServiceBroadcastsTest.kt

Model changes:
- Strip @CommonParcelize/@CommonParcelable from MeshUser, Position,
  DeviceMetrics, EnvironmentMetrics, MessageStatus, DataPacket
- Remove ByteStringParceler and CommonTypeParceler annotations
- Delete NodeInfo data class (zero external callers)
- Remove NodeEntity.toNodeInfo() conversion method
- Remove iOS CommonParcelable stubs from NoopStubs.kt

Data layer:
- Remove serviceBroadcasts constructor param from 8 manager classes
- Remove withBroadcast parameter from NodeManager.updateNode/installNodeInfo
- Simplify handleDataPacket/handleSpecializedDataPacket to Unit return
- Remove dead MeshService.actionReceived() companion function

Infrastructure:
- Remove NoopServiceBroadcasts from desktop stub and DI
- Remove kotlin.parcelize plugin from core:common and core:model
- Clean up all test mocks and verify calls

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jamesarich

.agent_memory/session_context.md

@@ -3,6 +3,19 @@
 # Do NOT edit or remove previous entries — stale state claims cause agent confusion.
 # Format: ## YYYY-MM-DD — <summary>
 
+## 2026-05-23 — Removed deprecated AIDL/API surface and switched Android to direct service control
+- Removed the entire `:core:api` module (AIDL files, published API build config, and module docs) and all build wiring to it (`settings.gradle.kts`, root convention module lists, CI publish/check workflows, `jitpack.yml`).
+- Re-architected Android service interaction away from binder binding:
+  - Deleted `MeshServiceClient`, generic `ServiceClient`, AIDL fake/contract test harness, and AIDL exception wrapper utility.
+  - Simplified `MeshService` into started-only foreground service (`onBind` now returns null) while preserving orchestrator lifecycle, notification updates, and wake-lock behavior.
+  - Kept Android-specific `AndroidRadioControllerImpl` as a thin extension of `DirectRadioControllerImpl` that still restarts `MeshService` after `setDeviceAddress(...)` to preserve address-change behavior.
+- Removed `core:service` dependency on `projects.core.api`; inlined intent/broadcast constants directly in `core/service/Constants.kt` to preserve action/extra string compatibility without the API module.
+- Hardened app manifest by making `MeshService` non-exported and removing the external service intent-filter action.
+- Updated app startup behavior: `MainActivity` now starts `MeshService` in `onStart()` directly instead of creating a binder client.
+- Cleaned active documentation/instructions to remove `core:api`/AIDL references (`README.md`, `core/service/README.md`, `core/model/README.md`, `.github/copilot-instructions.md`, `.skills/project-overview/SKILL.md`, `.skills/testing-ci/SKILL.md`, `codecov.yml`).
+- Validation run succeeded with full baseline command:
+  `./gradlew spotlessApply spotlessCheck detekt assembleDebug test allTests -Pci=true --continue`
+
 ## 2026-05-21 — Upgraded Chirpy to a fully-personalized Live Diagnostic Node & Mesh Assistant
 - Integrated `NodeRepository` into `GeminiNanoDocAssistant.kt` and the Google AI Koin dependency injection module (`GoogleAiModule.kt`).
 - Developed a dynamic live-state prompt formatting block within `buildPrompt(...)` that queries current hardware model, firmware version, connection status, GPS capability, channel utilization, airtime, battery level/voltage, user profile long/short names, and total registered mesh peer counts & active online peers directly from `NodeRepository`'s reactive flows.

.github/copilot-instructions.md

@@ -33,7 +33,7 @@ git submodule update --init
 
 KMP modules have different task names than pure-Android modules. Using the wrong name silently skips tests or fails resolution.
 
-| Intent | KMP modules (`core:*`, `feature:*`) | Android-only (`app`, `core:api`, `core:barcode`) |
+| Intent | KMP modules (`core:*`, `feature:*`) | Android-only (`app`, `core:barcode`) |
 |--------|--------------------------------------|--------------------------------------------------|
 | Run tests | `:module:allTests` | `:module:testFdroidDebugUnitTest` |
 | Detekt | `:module:detekt` (lifecycle task) | `:module:detekt` |
@@ -56,4 +56,3 @@ KMP modules have different task names than pure-Android modules. Using the wrong
 For additional context about technologies to be used, project structure,
 shell commands, and other important information, read the current plan
 <!-- SPECKIT END -->
-

.skills/project-overview/SKILL.md

@@ -5,7 +5,7 @@ Module directory, namespacing conventions, environment setup, and troubleshootin
 
 - **Build System:** Gradle (Kotlin DSL). JDK 21 REQUIRED. Target SDK: API 36. Min SDK: API 26.
 - **Flavors:** `fdroid` (OSS only) · `google` (Maps + DataDog analytics)
-- **Android-only Modules:** `core:api` (AIDL), `core:barcode` (CameraX). Shared contracts abstracted into `core:ui/commonMain`.
+- **Android-only Modules:** `core:barcode` (CameraX). Shared contracts abstracted into `core:ui/commonMain`.
 
 ## Codebase Map
 
@@ -28,7 +28,6 @@ Module directory, namespacing conventions, environment setup, and troubleshootin
 | `core:navigation` | Shared navigation keys/routes for Navigation 3 using `@Serializable sealed interface` hierarchies. `DeepLinkRouter` for typed backstack synthesis, and `MeshtasticNavSavedStateConfig` with `subclassesOfSealed()` for automatic polymorphic backstack persistence. |
 | `core:ui` | Shared Compose UI components (`MeshtasticAppShell`, `MeshtasticNavDisplay`, `MeshtasticNavigationSuite`, `AlertHost`, `SharedDialogs`, `PlaceholderScreen`, `MainAppBar`, dialogs, preferences) and platform abstractions. |
 | `core:service` | KMP service layer; Android bindings stay in `androidMain`. |
-| `core:api` | Public AIDL/API integration module for external clients. |
 | `core:prefs` | KMP preferences layer built on DataStore abstractions. |
 | `core:barcode` | Barcode scanning (Android-only). |
 | `core:nfc` | NFC abstractions (KMP). Android NFC hardware implementation in `androidMain`. |

.skills/testing-ci/SKILL.md

@@ -17,7 +17,7 @@ Run in a single invocation for routine changes to ensure code formatting, analys
 > In KMP modules, the `test` task name is **ambiguous**. Gradle matches both `testAndroid` and
 > `testAndroidHostTest` and refuses to run either, silently skipping KMP modules.
 > `allTests` is the `KotlinTestReport` lifecycle task registered by the KMP plugin.
-> Conversely, `allTests` does **not** cover pure-Android modules (`:androidApp`, `:core:api`, etc.), which is why both `test` and `allTests` are needed.
+> Conversely, `allTests` does **not** cover pure-Android modules (`:androidApp`, `:core:barcode`, etc.), which is why both `test` and `allTests` are needed.
 
 *Note: If testing Compose UI on the JVM (Robolectric) with Java 21, pin tests to `@Config(sdk = [34])` to avoid SDK 35 compatibility crashes.*
 
@@ -104,4 +104,3 @@ CI is defined in `.github/workflows/reusable-check.yml` and structured as four p
 - **Cache writes:** Trusted on `main` and merge queue runs; other refs use read-only cache.
 - **Path filtering:** `check-changes` in `pull-request.yml` must include module dirs plus build/workflow entrypoints (`build-logic/**`, `gradle/**`, `.github/workflows/**`, `gradlew`, `settings.gradle.kts`, etc.).
 - **AboutLibraries:** Runs in `offlineMode` by default (no GitHub/SPDX API calls). Release builds pass `-PaboutLibraries.release=true` via Fastlane/Gradle CLI to enable remote license fetching. Do NOT re-gate on `CI` or `GITHUB_TOKEN` alone.
-

README.md

@@ -87,7 +87,6 @@ Each module has its own README with details on its responsibilities, API surface
 
 | Module | Description |
 |---|---|
-| [core/api](core/api/README.md) | AIDL service API for third-party integrations |
 | [core/domain](core/domain/README.md) | Business-logic use cases (radio config, sessions, exports) |
 | [core/repository](core/repository/README.md) | Data & infrastructure contracts (RadioTransport, NodeRepository, ServiceRepository) |
 | [core/takserver](core/takserver/README.md) | Meshtastic ↔ TAK (ATAK/iTAK) bridge — CoT server & conversion |
@@ -123,13 +122,9 @@ Each module has its own README with details on its responsibilities, API surface
 
 You can help translate the app into your native language using [Crowdin](https://crowdin.meshtastic.org/android).
 
-## API & Integration
+## Integration
 
-Developers can integrate with the Meshtastic Android app using our published API library via **JitPack**. This allows third-party applications (like the ATAK plugin) to communicate with the mesh service via AIDL.
-
-For detailed integration instructions, see [core/api/README.md](core/api/README.md).
-
-Additionally, the app includes a built-in **Local TAK Server** feature that can be enabled in settings. This runs a local TCP server on port 8089 to allow ATAK clients to connect directly and route their traffic over the mesh.
+The app includes a built-in **Local TAK Server** feature that can be enabled in settings. This runs a local TCP server on port 8089 to allow ATAK clients to connect directly and route their traffic over the mesh.
 
 ## Building the Android App
 > [!WARNING]

androidApp/src/main/AndroidManifest.xml

@@ -161,16 +161,12 @@
             android:name="google_analytics_default_allow_analytics_storage"
             android:value="false" />
 
-        <!-- This is the public API for doing mesh radio operations from android apps -->
+        <!-- In-app mesh foreground service -->
         <service
             android:name="org.meshtastic.core.service.MeshService"
             android:enabled="true"
             android:foregroundServiceType="connectedDevice|location"
-            android:exported="true" tools:ignore="ExportedActivity">
-            <intent-filter>
-                <action android:name="com.geeksville.mesh.Service" />
-            </intent-filter>
-        </service>
+            android:exported="false" />
 
         <service
             android:name="androidx.appcompat.app.AppLocalesMetadataHolderService"

androidApp/src/main/kotlin/org/meshtastic/app/MainActivity.kt

@@ -63,7 +63,8 @@ import org.meshtastic.core.network.repository.UsbRepository
 import org.meshtastic.core.nfc.NfcScannerEffect
 import org.meshtastic.core.resources.Res
 import org.meshtastic.core.resources.channel_invalid
-import org.meshtastic.core.service.MeshServiceClient
+import org.meshtastic.core.service.MeshService
+import org.meshtastic.core.service.startService
 import org.meshtastic.core.ui.theme.AppTheme
 import org.meshtastic.core.ui.theme.MODE_DYNAMIC
 import org.meshtastic.core.ui.util.LocalAnalyticsIntroProvider
@@ -95,18 +96,9 @@ class MainActivity : AppCompatActivity() {
 
     private val usbRepository: UsbRepository by inject()
 
-    /**
-     * Activity-lifecycle-aware client that binds to the mesh service. Note: This is used implicitly as it registers
-     * itself as a LifecycleObserver in its init block.
-     */
-    internal val meshServiceClient: MeshServiceClient by inject { parametersOf(this) }
-
     override fun onCreate(savedInstanceState: Bundle?) {
         installSplashScreen()
 
-        // Eagerly evaluate lazy Koin dependency so it registers its LifecycleObserver
-        meshServiceClient.hashCode()
-
         super.onCreate(savedInstanceState)
 
         enableEdgeToEdge()
@@ -168,6 +160,11 @@ class MainActivity : AppCompatActivity() {
         handleIntent(intent)
     }
 
+    override fun onStart() {
+        super.onStart()
+        MeshService.startService(this)
+    }
+
     override fun onResume() {
         super.onResume()
         // Belt-and-suspenders for the Android 12+ attach-intent quirk: if the activity is

build-logic/convention/src/main/kotlin/RootConventionPlugin.kt

@@ -81,7 +81,6 @@ private val DEVICE_TEST_MODULES = listOf(":core:database", ":core:model")
 private val ALL_MODULES_FULL =
     listOf(
         ":androidApp",
-        ":core:api",
         ":core:barcode",
         ":core:ble",
         ":core:common",
@@ -115,7 +114,7 @@ private val ALL_MODULES_FULL =
     )
 
 /** Android-only modules that don't apply the KMP plugin. */
-private val ANDROID_ONLY_MODULES = setOf(":androidApp", ":core:api", ":core:barcode", ":feature:widget")
+private val ANDROID_ONLY_MODULES = setOf(":androidApp", ":core:barcode", ":feature:widget")
 
 /**
  * Modules excluded from Dokka aggregation. :core:proto contains only auto-generated Wire classes (no KDoc value) and
@@ -128,6 +127,6 @@ private fun allModules(): List<String> = ALL_MODULES_FULL
 
 /**
  * Modules that apply the KMP plugin and should be compiled for JVM + iOS targets. Excludes pure-Android modules
- * (:androidApp, :core:api, :core:barcode, :feature:widget) and the desktop JVM-only module.
+ * (:androidApp, :core:barcode, :feature:widget) and the desktop JVM-only module.
  */
 private fun kmpModules(): List<String> = allModules().filter { it !in ANDROID_ONLY_MODULES + ":desktopApp" }

codecov.yml

@@ -61,8 +61,6 @@ component_management:
 ignore:
   - "**/build/**"
   - "**/*.pb.kt"          # Generated Protobuf code
-  - "**/*.aidl"           # AIDL interface files
-  - "**/aidl/**"           # Generated AIDL code
   - "core/resources/**"   # Centralized resources
   - "**/test/**"          # Unit tests
   - "**/androidTest/**"   # Instrumented tests