Skip to content

fix(desktop): unbreak release builds (CMP beta03 + pwsh -P quoting)#5230

Merged
jamesarich merged 2 commits intomainfrom
fix/desktop-builds
Apr 23, 2026
Merged

fix(desktop): unbreak release builds (CMP beta03 + pwsh -P quoting)#5230
jamesarich merged 2 commits intomainfrom
fix/desktop-builds

Conversation

@jamesarich
Copy link
Copy Markdown
Collaborator

Run 24809290151 blew up the desktop release matrix in two distinct ways. This PR fixes both.

macOS + Ubuntu — :desktop:proguardReleaseJars failed

ProGuard aborted with 3 unresolved program-class member warnings:

Warning: com.patrykandpatrick.vico.compose.cartesian.ColorScaleShader:
  can't find referenced method
  'org.jetbrains.skia.Shader LinearGradientShader-VjE6UOU$default(...)'
  in program class androidx.compose.ui.graphics.ShaderKt
Warning: ColorScaleAreaFill / ColorScaleLineFill:
  can't find 'void setShader(org.jetbrains.skia.Shader)'
  in program class androidx.compose.ui.graphics.Paint
java.io.IOException: Please correct the above warnings first.

Vico 3.2.0-next.1 (PR #5191) requires Skia bindings that don't exist in compose-multiplatform 1.11.0-beta02. Bumping CMP to beta03 (and pulling along material3 alpha07, jetbrains-adaptive alpha07, and androidx-compose-bom-aligned 1.11.0) brings them in. Equivalent to renovate's pending #renovate/compose-multiplatform.

Windows — Task '.release=true' not found

PowerShell parsed -PaboutLibraries.release=true as member access on the token -PaboutLibraries, splitting it into two args and feeding .release=true to Gradle as a task name. Quoting the flag fixes it.

Verification

  • ./gradlew :desktop:proguardReleaseJars — green locally (was red)
  • ./gradlew spotlessApply detekt — clean

- Bump compose-multiplatform beta02→beta03 (and material3 alpha06→alpha07,
  androidx-compose-bom-aligned rc01→1.11.0, jetbrains-adaptive
  alpha06→alpha07). beta02 was missing the Skia bindings
  (LinearGradientShader-VjE6UOU$default and Paint.setShader(skia.Shader))
  that Vico 3.2.0-next.1's ColorScale shaders reference, making
  :desktop:proguardReleaseJars fail with 3 unresolved program-class
  member warnings on macOS and Linux runners.

- Quote -PaboutLibraries.release=true in release.yml. PowerShell on the
  Windows runner parsed the dot as member access on '-PaboutLibraries',
  splitting the token and handing '.release=true' to Gradle as a task
  name ("Task '.release=true' not found").

Verified locally: ./gradlew :desktop:proguardReleaseJars succeeds, and
./gradlew spotlessApply detekt is clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added bugfix PR tag repo Repository maintenance labels Apr 23, 2026
…sion forcing

- Switch the last two callers (NavigationAssemblyTest, BarcodeScannerTest)
  off the deprecated 'androidx.compose.ui.test.runComposeUiTest' to the v2
  variant under 'androidx.compose.ui.test.v2'. Compose 1.11 makes v2 the
  default and deprecates v1; everything else in the repo was already on v2.

- Fix AndroidCompose.kt to force androidx.compose.{ui,runtime,foundation,
  animation} to the AndroidX-aligned version (androidx-compose-bom-aligned)
  instead of the CMP version. CMP version strings (e.g. 1.11.0-beta03)
  are not published to the AndroidX repo, so the previous code only
  happened to work when CMP and AndroidX shared a version label
  (1.11.0-rc01). The bumped CMP beta03 surfaced this latent bug as
  'Could not find androidx.compose.ui:ui:1.11.0-beta03'. Update the
  libs.versions.toml comment to reflect the new source-of-truth.

Verified locally:
- ./gradlew :app:testFdroidDebugUnitTest :core:barcode:testFdroidDebugUnitTest
  (both migrated tests PASSED)
- ./gradlew :desktop:proguardReleaseJars (still green)
- ./gradlew spotlessApply detekt (clean)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesarich jamesarich merged commit 2c001c4 into main Apr 23, 2026
4 checks passed
@jamesarich jamesarich deleted the fix/desktop-builds branch April 23, 2026 11:22
Copilot AI pushed a commit that referenced this pull request Apr 24, 2026
…5230)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag repo Repository maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant